Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nrf: qspi: devicetree opcode properties are ignored #28635

Closed
pabigot opened this issue Sep 23, 2020 · 1 comment · Fixed by #28631
Closed

nrf: qspi: devicetree opcode properties are ignored #28635

pabigot opened this issue Sep 23, 2020 · 1 comment · Fixed by #28631
Assignees
@pabigot
Labels
area: Flash bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx

Comments

@pabigot
Copy link
Collaborator

pabigot commented Sep 23, 2020

#24378 changed the way a property that was accessed via its enum value was referenced, so the readoc property was checked as if it were named readoc-enum. The effect is that the devicetree readoc and writeoc properties are being ignored.
@pabigot pabigot added bug The issue is a bug, or the PR is fixing a bug area: Flash platform: nRF Nordic nRFx labels Sep 23, 2020
@pabigot pabigot self-assigned this Sep 23, 2020
@pabigot pabigot mentioned this issue Sep 23, 2020
Merged
@pabigot
Copy link
Collaborator Author

pabigot commented Sep 23, 2020

@ioannisg @nvlsianpu @MaureenHelm @nashif priority? I'd like to see this fixed in 2.4.0. (Though the referenced PR is intended to add support for a new platform it's actually fixing this bug.)

MaureenHelm pushed a commit that referenced this issue Sep 23, 2020
@sw @MaureenHelm
drivers: nrf_qspi: fix devicetree opcode references
381cac1 
The condition used to detect presence of optional devicetree
properties that specify read and write opcodes was inadvertently
changed to something that will never be true.  Update the check and
the property extraction to restore the original behavior.

Fixes #28635.

Signed-off-by: Stephan Walter <stephan@walter.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pabigot pabigot

Labels
area: Flash bug The issue is a bug, or the PR is fixing a bug platform: nRF Nordic nRFx
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

drivers/nrf_qspi: fix devicetree opcode references
1 participant
@pabigot