Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stm32 uart async driver changes offset after callback #31973

Closed
jasuramme opened this issue Feb 4, 2021 · 0 comments · Fixed by #31975
Closed

Stm32 uart async driver changes offset after callback #31973

jasuramme opened this issue Feb 4, 2021 · 0 comments · Fixed by #31975
Assignees
@erwango
Labels
bug The issue is a bug, or the PR is fixing a bug platform: STM32 ST Micro STM32 priority: low Low impact/importance bug

Comments

@jasuramme
Copy link

Describe the bug
Stm32 uart async driver changes itself state (offset data) after calling the callback function with rx_ready event.
If you try to restart rx receive (for example, change buffer just after rx_ready event), you will have bad offset data (should be equal to zero)

To Reproduce
Call uart->rx_enable from uart async callback

Expected behavior
Driver shouldn't change itself state after ready event

Impact
You cannot run rx_enable from uart callback

Environment (please complete the following information):

  • OS: Archlinux
  • Toolchain Zephyr SDK, arm-none-eabi 10.2.0
  • Commit SHA or Version used 1ee82a1
@jasuramme jasuramme added the bug The issue is a bug, or the PR is fixing a bug label Feb 4, 2021
@jasuramme jasuramme mentioned this issue Feb 4, 2021
Merged
@erwango erwango self-assigned this Feb 4, 2021
@erwango erwango added platform: STM32 ST Micro STM32 priority: low Low impact/importance bug labels Feb 4, 2021
jasuramme added a commit to jasuramme/zephyr that referenced this issue Feb 4, 2021
@jasuramme
Drivers: serial: Fix stm32 uart async api callback
5578fe1 
Fixes the bug when driver changes offset after
the callback call. When you have the ready event
you suppose no changes in driver data after that.
Fixes zephyrproject-rtos#31973

Signed-off-by: Alexander Shuklin <jasuramme@gmail.com>
nashif pushed a commit that referenced this issue Feb 4, 2021
@jasuramme @nashif
Drivers: serial: Fix stm32 uart async api callback
6831b8b 
Fixes the bug when driver changes offset after
the callback call. When you have the ready event
you suppose no changes in driver data after that.
Fixes #31973

Signed-off-by: Alexander Shuklin <jasuramme@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erwango erwango

Labels
bug The issue is a bug, or the PR is fixing a bug platform: STM32 ST Micro STM32 priority: low Low impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drivers: serial: Fix stm32 uart async api callback jasuramme/zephyr
2 participants
@jasuramme @erwango