-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Würth Elektronik Sensors SDK code for use in sensor drivers #47021
Comments
I am a bit concerned about future updates if we integrate this in-tree. Every time you need to update to a more recent version of your SDK you will have to reformat the code to fit Zephyr's coding style and guidelines? |
Also you apparently skipped the section on maintainership here: https://github.com/zephyrproject-rtos/zephyr/blob/main/.github/ISSUE_TEMPLATE/ext-source.md Could you please add this section? |
I added the section on maintainership.
Actually, we intend to reformat the existing SDK according to Zephyr's requirements and keep it that way. So that should not be an issue. |
OK. Unfortunately the agenda for this week's TSC meeting was sent yesterday, so this will need to be discussed in next week's meeting. |
Ok, thanks for the info. |
We have discussed the matter internally and decided to go with integration as a module after all, as this is probably the cleanest solution. I have changed the issue text accordingly. |
OK, very well. I will make sure that the TSC is aware of this change. |
The license does not look like Apache 2.0.
There's also this in the license file:
|
@yath-eiSmart you will need to fix the license. It doesn't have to be Apache v2, but it has to be OSI-approved and non-copyleft. Typical alternatives to Apache v2 are:
|
Thank you for the feedback. We intend to release the module using the Apache 2.0 license. |
@yath-eiSmart this was discussed at the TSC meeting today, and there was a request to see the future module repo in some shape or form, including:
So we would ask you to create a repo under whatever GitHub organization you want (does not need to be the official Würth one, can be your own user) that reflects the exact contents of the future module. Thanks for your patience! |
@carlescufi thank you for the update. We have created a repo for the new module as requested: https://github.com/WE-eiSmart/zephyr_hal_we |
This looks great, thank you! |
Thank you for the feedback! What are the next steps? Has this been discussed by the TSC? We have prepared the drivers for using the external SDK module, so we are ready to proceed with the contribution. |
Thank you for addressing the license issue so quickly; agree with @carlescufi it looks good now. The TSC plans to make a decision next week.
You can go ahead and send a draft PR that points west.yml to your module repo. We won't be able to merge it until after the TSC approves and creates a mirror in the zephyrproject-rtos org, but we can start code reviews on the driver shims in the meantime. Please don't send all the driver shims in one PR as that is difficult to review. The code review process will go more smoothly if you send one driver shim per PR. Thank you! |
Perfect, thanks for the update! |
The TSC approved this today. The repository will be created shortly. |
@yath-eiSmart what should the repo be called? |
Hey @carlescufi , BR Matthias |
Thanks @mah-eiSmart. I brought this up in today's TSC and |
Hello @carlescufi , |
@carlescufi Great, thanks! Unfortunately, I currently don't have write access to the repo - I was out of office and the invitation probably expired. Could you reinvite me? Thanks! |
Adding mah-eiSmart as maintainer for hal_wurthelektronik. Link: zephyrproject-rtos#47021 (comment) Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
Adding mah-eiSmart as maintainer for hal_wurthelektronik. Link: #47021 (comment) Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
Adding mah-eiSmart as maintainer for hal_wurthelektronik. (cherry picked from commit 6030b85) Original-Link: zephyrproject-rtos/zephyr#47021 (comment) Original-Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com> GitOrigin-RevId: 6030b85 Change-Id: I3de050a13fc3888c9e6f1f85f869de4774115046 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/3906298 Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com> Commit-Queue: Fabio Baltieri <fabiobaltieri@google.com> Tested-by: Fabio Baltieri <fabiobaltieri@google.com> Tested-by: CopyBot Service Account <copybot.service@gmail.com>
Origin
WE Sensors SDK
https://github.com/WurthElektronik/Sensors-SDK_STM32
Purpose
Drivers for sensors by Würth Elektronik.
Mode of integration
We would like to integrate the required code as a module.
Suggested module name: "hal_we".
Maintainership
@mah-eiSmart
Pull Request
#46920
Description
The aforementioned pull request adds drivers and examples for Würth Elektronik sensors to Zephyr. The drivers internally use the Würth Elektronik Sensors SDK code, which we plan to integrate as a module (the pull request currently has the SDK code integrated into Zephyr's main tree, this will be moved to a module).
Dependencies
None
Revision
Based on the next SDK version to be released (2.2).
License
Apache-2.0
The text was updated successfully, but these errors were encountered: