Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRAM increase in Bluetooth [samples: bbc_microbit: pong fails to build] #47428

Closed
galak opened this issue Jul 6, 2022 · 3 comments · Fixed by #47591
Closed

SRAM increase in Bluetooth [samples: bbc_microbit: pong fails to build] #47428

galak opened this issue Jul 6, 2022 · 3 comments · Fixed by #47591
Assignees
@jori-nordic
Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug

Comments

@galak
Copy link
Collaborator

galak commented Jul 6, 2022

when trying to build samples/boards/bbc_microbit/pong

I get the following error:

/opt/zephyr-sdk-0.14.2/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/10.3.0/../../../../arm-zephyr-eabi/bin/ld.bfd: zephyr_pre0.elf section `noinit' will not fit in region `SRAM'
/opt/zephyr-sdk-0.14.2/arm-zephyr-eabi/bin/../lib/gcc/arm-zephyr-eabi/10.3.0/../../../../arm-zephyr-eabi/bin/ld.bfd: region `SRAM' overflowed by 1079 bytes
collect2: error: ld returned 1 exit status

Doing a git bisect, tracked it down to:

commit 3c5bf50 (refs/bisect/bad)
Author: Jonathan Rico jonathan.rico@nordicsemi.no
Date: Mon May 30 16:08:11 2022 +0200

Bluetooth: host: add dedicated WQ for long-running tasks
@galak galak added the bug The issue is a bug, or the PR is fixing a bug label Jul 6, 2022
@galak galak mentioned this issue Jul 6, 2022
Merged
@galak galak changed the title samples: bbc_microbit: pong fails to build SRAM increase in Bluetooth [samples: bbc_microbit: pong fails to build] Jul 6, 2022
@mmahadevan108
Copy link
Collaborator

@jori-nordic, can you help take a look at this issue.

@jori-nordic
Copy link
Contributor

@carlescufi do you know why this wasn't caught in CI ? Aren't we building all the samples in the oncommit ?

jori-nordic added a commit to jori-nordic/zephyr that referenced this issue Jul 11, 2022
@jori-nordic
samples: boards: fix bbc_microbit pong build
0189aa0 
The GATT caching feature isn't needed, and was making the memory
consumption blow up because of the recent addition of `long_wq` for
deferred work.

Fixes zephyrproject-rtos#47428 .

Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
@jori-nordic jori-nordic mentioned this issue Jul 11, 2022
Merged
@carlescufi
Copy link
Member

@carlescufi do you know why this wasn't caught in CI ? Aren't we building all the samples in the oncommit ?

We dismiss RAM/ROM overflows instead of reporting them as build failures.

carlescufi pushed a commit that referenced this issue Jul 11, 2022
@jori-nordic @carlescufi
samples: boards: fix bbc_microbit pong build
1f226e0 
The GATT caching feature isn't needed, and was making the memory
consumption blow up because of the recent addition of `long_wq` for
deferred work.

Fixes #47428 .

Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jori-nordic jori-nordic

Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

samples: boards: fix bbc_microbit pong build jori-nordic/zephyr
4 participants
@carlescufi @galak @mmahadevan108 @jori-nordic