Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI should use the same generator as the sanitycheck default #5726

Closed
SebastianBoe opened this issue Jan 18, 2018 · 4 comments
Closed

CI should use the same generator as the sanitycheck default #5726

SebastianBoe opened this issue Jan 18, 2018 · 4 comments
Assignees
@nashif
Labels
Enhancement Changes/Updates/Additions to existing features

Comments

@SebastianBoe
Copy link
Collaborator

It is important that it is easy to reproduce CI issues locally. Using
the same sanitycheck options locally and in CI helps in this
regard. Specifically, Ninja and Make can produce different results and
therefore the default generator should be the same for sanitycheck and
shippable.

Solution proposal

Have sanitycheck default to Ninja as soon as it is stable enough.
@SebastianBoe
Copy link
Collaborator Author

Blocked by #5725

@SebastianBoe
Copy link
Collaborator Author

Solution proposal: SebastianBoe@8ba5d93

@nashif nashif self-assigned this Jan 19, 2018
@nashif nashif added the Enhancement Changes/Updates/Additions to existing features label Jan 19, 2018
@galak
Copy link
Collaborator

galak commented Jan 26, 2018

This should also deal with -R. We should have sanitycheck default to enabling asserts and add an option to explicitly disable.

galak added a commit to galak/zephyr that referenced this issue Jan 26, 2018
@galak
sanitycheck: default to assertions being enabled
d16ae16 
Changed the default behavior for when we run sanitycheck to match the -R
flag that turns on assertions.  Introduced a --disable-asserts option if
we desire to explicitly turn of asserts.

This matches behavior that our CI builds have been doing and addresses
part of zephyrproject-rtos#5726.

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
@galak galak mentioned this issue Jan 26, 2018
Merged
@galak
Copy link
Collaborator

galak commented Jan 26, 2018

This should also deal with -R. We should have sanitycheck default to enabling asserts and add an option to explicitly disable.

The -R part should be addressed by #5841. Once merged we can update CI to drop -R

nashif pushed a commit that referenced this issue Jan 26, 2018
@galak
sanitycheck: default to assertions being enabled
0d48cbe 
Changed the default behavior for when we run sanitycheck to match the -R
flag that turns on assertions.  Introduced a --disable-asserts option if
we desire to explicitly turn of asserts.

This matches behavior that our CI builds have been doing and addresses
part of #5726.

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
@nashif nashif mentioned this issue Feb 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nashif nashif

Labels
Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nashif @SebastianBoe @galak