sanitycheck: default to assertions being enabled #5841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the default behavior for when we run sanitycheck to match the -R flag that turns on assertions. Introduced a --disable-asserts option if we desire to explicitly turn of asserts. This matches behavior that our CI builds have been doing and addresses part of zephyrproject-rtos#5726. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
Codecov Report
@@ Coverage Diff @@
## master #5841 +/- ##
==========================================
- Coverage 54.33% 54.32% -0.02%
==========================================
Files 457 457
Lines 43298 43298
Branches 8302 8302
==========================================
- Hits 23528 23523 -5
- Misses 19631 19636 +5
Partials 139 139
Continue to review full report at Codecov.
|
andrewboie
approved these changes
Jan 26, 2018
| help="Build all test cases with assertions enabled. " | ||
| "Default to assertions being enabled.") | ||
| parser.add_argument("--disable-asserts", action="store_false", | ||
| dest="enable_asserts", |
There was a problem hiding this comment.
This is much better than what I came up with for switching between make and Ninja. Was not aware that two arguments could have the same 'dest'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the default behavior for when we run sanitycheck to match the -R
flag that turns on assertions. Introduced a --disable-asserts option if
we desire to explicitly turn of asserts.
This matches behavior that our CI builds have been doing and addresses
part of #5726.
Signed-off-by: Kumar Gala kumar.gala@linaro.org