xtools build hard-coded to use IAMCU compiler for all x86 targets

[andrewboie]

I have brew binutils 2.30 installed, but it installs it as "greadelf" and not "readelf" and CMake can't find it. Creating a symlink did not help.

CMake Error at /Users/andrew/zephyr/cmake/extensions.cmake:984 (message): No such file or directory: CMAKE_READELF: 'CMAKE_READELF-NOTFOUND' Call Stack (most recent call first): /Users/andrew/zephyr/cmake/compiler/gcc.cmake:14 (assert_exists) /Users/andrew/zephyr/cmake/toolchain.cmake:38 (include) /Users/andrew/zephyr/cmake/app/boilerplate.cmake:242 (include) CMakeLists.txt:1 (include)

[andrewboie]

Looking at CMakeCache.txt, it can't find any of the toolchain executables.

$ cat CMakeCache.txt | grep NOTFOUND
CMAKE_AR:FILEPATH=CMAKE_AR-NOTFOUND
CMAKE_C_COMPILER:FILEPATH=CMAKE_C_COMPILER-NOTFOUND
CMAKE_GDB:FILEPATH=CMAKE_GDB-NOTFOUND
CMAKE_NM:FILEPATH=CMAKE_NM-NOTFOUND
CMAKE_OBJCOPY:FILEPATH=CMAKE_OBJCOPY-NOTFOUND
CMAKE_OBJDUMP:FILEPATH=CMAKE_OBJDUMP-NOTFOUND
CMAKE_RANLIB:FILEPATH=CMAKE_RANLIB-NOTFOUND
CMAKE_READELF:FILEPATH=CMAKE_READELF-NOTFOUND
OPENOCD:FILEPATH=OPENOCD-NOTFOUND

Is $CROSS_COMPILE not being set properly with xtools?

I have

$ env | grep TOOLCHAIN
XTOOLS_TOOLCHAIN_PATH=/Volumes/CrossToolNG/x-tools
ZEPHYR_TOOLCHAIN_VARIANT=xtools

Contents of my toolchain installation

https://pastebin.com/7mtiBAN9

[andrewboie]

Our xtools.cmake is broken, it's hard-coded to use the IAMCU compiler for some reason for ALL x86 targets not just the ones that actually do use IAMCU (arduino_101, qemu_x86_iamcu). I had to change it:

diff --git a/cmake/toolchain/xtools.cmake b/cmake/toolchain/xtools.cmake
index 83107bae0..e6ed38605 100644
--- a/cmake/toolchain/xtools.cmake
+++ b/cmake/toolchain/xtools.cmake
@@ -7,7 +7,7 @@ set(TOOLCHAIN_HOME ${XTOOLS_TOOLCHAIN_PATH})
 set(COMPILER gcc)

 set(CROSS_COMPILE_TARGET_arm arm-none-eabi)
-set(CROSS_COMPILE_TARGET_x86 i586-zephyr-elfiamcu)
+set(CROSS_COMPILE_TARGET_x86 i586-zephyr-elf)

 set(CROSS_COMPILE_TARGET     ${CROSS_COMPILE_TARGET_${ARCH}})
 set(SYSROOT_TARGET           ${CROSS_COMPILE_TARGET})

[andrewboie]

We could improve the error message too.

"CMake Error at /Users/andrew/zephyr/cmake/extensions.cmake:984 (message): No such file or directory: CMAKE_READELF: 'CMAKE_READELF-NOTFOUND'"

Actually means that the build can't find the toolchain.

[andrewboie]

The error message is now a lot more useful.
I think it still shouldn't default to IAMCU for all x86 targets though.