Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor self nominate jeppenodgaard #73716

Closed
jeppenodgaard opened this issue Jun 4, 2024 · 9 comments
Closed

Contributor self nominate jeppenodgaard #73716

jeppenodgaard opened this issue Jun 4, 2024 · 9 comments
Assignees

Comments

@jeppenodgaard
Copy link
Collaborator

Background

The TSC Project Roles defines the main roles for the Zephyr Project, including
Maintainer, Collaborator, and Contributor.

By default anyone that contributes code or documentation is a Contributor, but
with the lowest GitHub Permission Level of Read. For example, Contributors
with Read permission do not have the permission to add reviewers to a pull
request.

Use this template to nominate a GitHub user for the Contributor role with
Triage permission level, which allows the user to add reviewers to a pull
request and be added as a reviewer by other users.

Nomination

GitHub User

Provide the following information about the GitHub user:

  1. Full Name: Jeppe Odgaard
  2. GitHub username: @jeppenodgaard

Supporting Documents

Add links to 3-5 GitHub pull requests, in the Zephyr project, authored or
reviewed by the GitHub user that demonstrate the user's dedication to the
Zephyr project.

Author:

Reviewer:

@jeppenodgaard
Copy link
Collaborator Author

The issue should probably have been created before this related PR:
#72896

@teburd
Copy link
Collaborator

teburd commented Jun 5, 2024

+1 from me

@kartben
Copy link
Collaborator

kartben commented Jun 7, 2024

+1

1 similar comment
@henrikbrixandersen
Copy link
Member

+1

@nashif
Copy link
Member

nashif commented Jun 12, 2024

@nashif nashif closed this as completed Jun 12, 2024
@jeppenodgaard
Copy link
Collaborator Author

My PR approval currently does not count:
#73141 (review)

I think I currently have triage access. The collaborator PR was opened and merged before this issue. Could that be causing problems?

@kartben
Copy link
Collaborator

kartben commented Jun 13, 2024

My PR approval currently does not count: #73141 (review)

I think I currently have triage access. The collaborator PR was opened and merged before this issue. Could that be causing problems?

and you accepted the aforementioned invite, yes?

@jeppenodgaard
Copy link
Collaborator Author

My PR approval currently does not count: #73141 (review)
I think I currently have triage access. The collaborator PR was opened and merged before this issue. Could that be causing problems?

and you accepted the aforementioned invite, yes?

Yes. It shows up under https://github.com/settings/organizations now.

@jeppenodgaard
Copy link
Collaborator Author

@nashif do you have any idea why my approvals does not count?
It says "Collaborator" next to my name and I am "Drivers: Sensors" collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants