Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev add i2s stm32h5 #72990

Merged
merged 8 commits into from
May 28, 2024
Merged

Dev add i2s stm32h5 #72990

merged 8 commits into from
May 28, 2024

Conversation

marwaiehm-st
Copy link
Collaborator

@marwaiehm-st marwaiehm-st commented May 19, 2024 •
edited

Add the STM32H5 family support for the test I2s_speed.
The driver is updated to handle correctly the commands TRIGGER_DRAIN.

@marwaiehm-st marwaiehm-st added area: DMA Direct Memory Access platform: STM32 ST Micro STM32 area: I2S labels May 19, 2024
@marwaiehm-st marwaiehm-st marked this pull request as ready for review May 19, 2024 15:31
@erwango
Copy link
Member

erwango commented May 20, 2024

@jeppenodgaard ^^

jeppenodgaard
jeppenodgaard reviewed May 20, 2024
View reviewed changes
drivers/i2s/i2s_ll_stm32.c Outdated Show resolved Hide resolved
drivers/i2s/i2s_ll_stm32.c Outdated Show resolved Hide resolved
erwango
erwango requested changes May 21, 2024
View reviewed changes
dts/arm/st/h5/stm32h5.dtsi Outdated Show resolved Hide resolved
dts/arm/st/h5/stm32h5.dtsi Outdated Show resolved Hide resolved
dts/arm/st/h5/stm32h5.dtsi Outdated Show resolved Hide resolved
dts/arm/st/h5/stm32h5.dtsi Outdated Show resolved Hide resolved
dts/arm/st/h5/stm32h5.dtsi Show resolved Hide resolved
tests/drivers/i2s/i2s_speed/boards/stm32h573i_dk.overlay Outdated Show resolved Hide resolved
drivers/i2s/i2s_ll_stm32.c Show resolved Hide resolved
drivers/i2s/i2s_ll_stm32.c Show resolved Hide resolved
@zephyrbot zephyrbot added the area: Devicetree Binding PR modifies or adds a Device Tree binding label May 21, 2024
@zephyrbot zephyrbot requested review from decsny and galak May 21, 2024 16:14
@decsny decsny removed their request for review May 21, 2024 19:01
erwango
erwango requested changes May 22, 2024
View reviewed changes
drivers/dma/dma_stm32u5.c Outdated Show resolved Hide resolved
drivers/i2s/i2s_ll_stm32.c Outdated Show resolved Hide resolved
drivers/i2s/i2s_ll_stm32.c Show resolved Hide resolved
erwango
erwango reviewed May 23, 2024
View reviewed changes
drivers/i2s/i2s_ll_stm32.c Outdated Show resolved Hide resolved
erwango
erwango requested changes May 23, 2024
View reviewed changes
drivers/i2s/i2s_ll_stm32.h Show resolved Hide resolved
drivers/i2s/i2s_ll_stm32.h Outdated Show resolved Hide resolved
@francktheb @marwaiehm-st
dts: arm: st: h5: add I2S nodes
108b4ae 
Addition of I2S nodes

Signed-off-by: Franck Thebault <franck.thebault@st.com>
Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <marwa.ibenelhadjmessaoud-ext@st.com>
@francktheb @marwaiehm-st
tests: drivers: i2s: speed: add stm32h5 support
63725b3 
Test on STM32H573i disco board , only the Tx transfer is ok.

Signed-off-by: Franck Thebault <franck.thebault@st.com>
Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <marwa.ibenelhadjmessaoud-ext@st.com>
@marwaiehm-st marwaiehm-st requested a review from erwango May 24, 2024 09:15
mathieuchopstm
mathieuchopstm suggested changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@mathieuchopstm mathieuchopstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM.
A few points to review:

drivers/i2s/i2s_ll_stm32.c Show resolved Hide resolved
drivers/i2s/i2s_ll_stm32.c Outdated Show resolved Hide resolved
drivers/i2s/i2s_ll_stm32.c Outdated Show resolved Hide resolved
drivers/i2s/i2s_ll_stm32.c Outdated Show resolved Hide resolved
drivers/i2s/i2s_ll_stm32.h Outdated Show resolved Hide resolved
mathieuchopstm
mathieuchopstm suggested changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@mathieuchopstm mathieuchopstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting there! A few points to iron out:

drivers/i2s/i2s_ll_stm32.c Show resolved Hide resolved
drivers/i2s/i2s_ll_stm32.c Outdated Show resolved Hide resolved
drivers/i2s/i2s_ll_stm32.c Outdated Show resolved Hide resolved
drivers/i2s/i2s_ll_stm32.c Show resolved Hide resolved
drivers/i2s/i2s_ll_stm32.c Outdated Show resolved Hide resolved
drivers/i2s/i2s_ll_stm32.c Outdated Show resolved Hide resolved
drivers/i2s/i2s_ll_stm32.c Outdated Show resolved Hide resolved
drivers/i2s/i2s_ll_stm32.c Outdated Show resolved Hide resolved
mathieuchopstm
mathieuchopstm approved these changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@mathieuchopstm mathieuchopstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny non-blockers, otherwise LGTM.

Nit: stream->last_block seems to have become a dead variable, could used to be removed if so.

drivers/i2s/i2s_ll_stm32.c Outdated Show resolved Hide resolved
drivers/i2s/i2s_ll_stm32.c Show resolved Hide resolved
@marwaiehm-st
include: zephyr: dt-bindings: dma: Add flag STM32_DMA_16BITS
8e9aa8f 
Add flag STM32_DMA_16BITS as a combination of
STM32_DMA_PERIPH_16BITS and STM32_DMA_MEM_16BITS

Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <marwa.ibenelhadjmessaoud-ext@st.com>
@marwaiehm-st
drivers: i2s : enable rx path for H7 and H5
b3d9b78 
In i2s_stm32_isr, remove the errors from SR register
   i2s_stm32_configure, enable the rx path for H7 I2S compatible IP

Signed-off-by: Franck Thebault <franck.thebault@st.com>
Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <marwa.ibenelhadjmessaoud-ext@st.com>
@marwaiehm-st
drivers: dma: u5: fix dma reload
8675a19 
In dma_stm32_reload, the size is the number of bytes and not number
of elements.

Signed-off-by: Franck Thebault <franck.thebault@st.com>
Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <marwa.ibenelhadjmessaoud-ext@st.com>
@marwaiehm-st
drivers: i2s: Add DMA busy function
3f13ab6 
Add the function ll_func_i2s_dma_busy to be able to check the
transmission of all the DMA TX packet.

Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <marwa.ibenelhadjmessaoud-ext@st.com>
francktheb and others added 2 commits May 27, 2024 17:26
@francktheb @marwaiehm-st
drivers: i2s : correct TRIGGER_DRAIN and TRIGGER_STOP commands
0d3ded7 
Correction of the handling of Tx audio samples via DMA

Signed-off-by: Franck Thebault <franck.thebault@st.com>
Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <marwa.ibenelhadjmessaoud-ext@st.com>
@marwaiehm-st
drivers: i2s: i2s_ll_stm32: tx_stream_disable: Add busy wait
1e506b4 
Add a k_busy_wait to the function tx_stream_disable
to be able to complete the drain of the TX queue before disabling.

Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <marwa.ibenelhadjmessaoud-ext@st.com>
mathieuchopstm
mathieuchopstm approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@mathieuchopstm mathieuchopstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aescolar aescolar merged commit fdd6627 into zephyrproject-rtos:main May 28, 2024
22 checks passed
@jeppenodgaard jeppenodgaard mentioned this pull request Jun 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeppenodgaard jeppenodgaard jeppenodgaard approved these changes

@anangl anangl anangl approved these changes

@erwango erwango erwango approved these changes

@mathieuchopstm mathieuchopstm mathieuchopstm approved these changes

@avisconti avisconti Awaiting requested review from avisconti avisconti is a code owner

@ajarmouni-st ajarmouni-st Awaiting requested review from ajarmouni-st

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@teburd teburd Awaiting requested review from teburd

@galak galak Awaiting requested review from galak

Assignees

@anangl anangl

Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: DMA Direct Memory Access area: I2S platform: STM32 ST Micro STM32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@marwaiehm-st @erwango @jeppenodgaard @anangl @ajarmouni-st @mathieuchopstm @zephyrbot @aescolar @francktheb