Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usb: update bcdUSB to 2.00 #7570

Closed
jfischer-no opened this issue May 16, 2018 · 5 comments · Fixed by #7822
Closed

usb: update bcdUSB to 2.00 #7570

jfischer-no opened this issue May 16, 2018 · 5 comments · Fixed by #7822
Labels
area: USB Universal Serial Bus Enhancement Changes/Updates/Additions to existing features
Milestone

Comments

@jfischer-no
Copy link
Collaborator

jfischer-no commented May 16, 2018

There is suggestion/need to increase bcdUSB to 2.00. Are all supported controllers USB Rev. 2.0 compliant?

  • Kinetis (USBFSOTG) is USB 2.0 full-speed/low-speed compliant
  • NRF52 is Fully compliant to Universal Serial Bus Specification Revision 2.0 Full Speed part
  • STM32 Cube HAL, are all supported controllers USB 2.0 compliant ? 🆗 (STM32F1, STM32F3, STM32F4, STM32L4 USB 2.0 Specification compliant )
  • usb_dc_dw.c, usb: add USB2.0 device and High Speed support #7356
  • usb_dc_sam0.c ? 🆗 (SAM D21, SAM R21 Family module complies with the Universal Serial Bus (USB) 2.1
    specification)

@ydamigos, @carlescufi, @nzmichaelh @finikorg @loicpoulain

@jfischer-no jfischer-no added the area: USB Universal Serial Bus label May 16, 2018
@carlescufi
Copy link
Member

CC @pawelzadrozniak, will defer to him

@ydamigos
Copy link
Collaborator

As far as I know, all supported controllers on STM32 SoCs are USB 2.0 compliant.

@pawelzadrozniak
Copy link
Collaborator

There could be a configuration option to choose between 1.1 and 2.0.

@jfischer-no
Copy link
Collaborator Author

There could be a configuration option to choose between 1.1 and 2.0.

Only if there is no other way. e.g. if we have a non 2.0 compatible controller

@nashif nashif added the Enhancement Changes/Updates/Additions to existing features label May 17, 2018
@nzmichaelh
Copy link
Collaborator

The SAM0 is USB2 so you're good there. I can't think of any reasons to support USB1.1.

jfischer-no added a commit to jfischer-no/zephyr that referenced this issue May 23, 2018
Update bcdUSB to 2.00

resolves zephyrproject-rtos#7570

Signed-off-by: Johann Fischer <j.fischer@phytec.de>
@nashif nashif added this to the v1.13.0 milestone May 28, 2018
nashif pushed a commit that referenced this issue Jun 11, 2018
Update bcdUSB to 2.00

resolves #7570

Signed-off-by: Johann Fischer <j.fischer@phytec.de>
pawelzadrozniak added a commit to pawelzadrozniak/zephyr that referenced this issue Jun 27, 2018
bcdUSB has been previously updated from 1.1 to 2.0 in default
device descriptor, but not in DFU class. After USB bus reset
performed by dfu-util, alternative descriptor is registered
with bcdUSB set to 1.1. This mismatch causes communication failure.
DFU descriptor's bcdUSB has been updated to match default one.

Relates to zephyrproject-rtos#7570

Signed-off-by: Paweł Zadrożniak <pawel.zadrozniak@nordicsemi.no>
carlescufi pushed a commit that referenced this issue Jun 27, 2018
bcdUSB has been previously updated from 1.1 to 2.0 in default
device descriptor, but not in DFU class. After USB bus reset
performed by dfu-util, alternative descriptor is registered
with bcdUSB set to 1.1. This mismatch causes communication failure.
DFU descriptor's bcdUSB has been updated to match default one.

Relates to #7570

Signed-off-by: Paweł Zadrożniak <pawel.zadrozniak@nordicsemi.no>
pawelzadrozniak added a commit to pawelzadrozniak/zephyr that referenced this issue Jul 5, 2018
bcdUSB has been previously updated from 1.1 to 2.0 in default
device descriptor, but not in DFU class. After USB bus reset
performed by dfu-util, alternative descriptor is registered
with bcdUSB set to 1.1. This mismatch causes communication failure.
DFU descriptor's bcdUSB has been updated to match default one.

Relates to zephyrproject-rtos#7570

Signed-off-by: Paweł Zadrożniak <pawel.zadrozniak@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: USB Universal Serial Bus Enhancement Changes/Updates/Additions to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants