CONFIG_BMM150_SET_ATTR not defined (and now removed), giving dead code #7848
Assignees
Labels
area: Sensors
Sensors
bug
The issue is a bug, or the PR is fixing a bug
priority: low
Low impact/importance bug
Comments
|
CC @punitvara I'm trying to get rid of all assignments to undefined Kconfig symbols, so it can be turned into an error during testing. |
MaureenHelm
added
bug
ulfalizer
added a commit
to ulfalizer/zephyr
that referenced
this issue
May 25, 2018
This symbol never existed, and has some dead code associated with it: zephyrproject-rtos#7848 Just remove the assignment to the undefined Kconfig symbol for now. The associated code could be removed separately if it isn't needed anymore. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
ulfalizer
changed the title
|
I'm removing just the |
galak
pushed a commit
that referenced
this issue
May 25, 2018
This symbol never existed, and has some dead code associated with it: #7848 Just remove the assignment to the undefined Kconfig symbol for now. The associated code could be removed separately if it isn't needed anymore. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
|
@ulfalizer Extra code could be useful when interrupt functionality will be added. @ulfalizer @MaureenHelm Do you suggest to remove extra code as of now ? |
|
@ulfalizer ?? |
|
@punitvara No panic to remove it on my part, if you think it might get used. |
|
Ok no problem @ulfalizer Closing this issue as code is reusable to enable interrupt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
drivers/sensor/bmm150/Kconfighas no definition forBMM150_SET_ATTR, which is set bysamples/sensor/bmm150/prj.conf.drivers/sensor/bmm150/bmm150.chas a bunch of#if defined(BMM150_SET_ATTR)(and some#if defined(BMM150_SET_ATTR_REP)), which are probably dead code. If those are meant to be Kconfig symbols, they'll need Kconfig definitions (and aCONFIG_prefix in the#ifdefs).The text was updated successfully, but these errors were encountered: