Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples/mpu/mem_domain_apis_test/kernel.memory_protection.memory_domains fails to build #8593

Closed
galak opened this issue Jun 27, 2018 · 1 comment
Closed

samples/mpu/mem_domain_apis_test/kernel.memory_protection.memory_domains fails to build #8593

galak opened this issue Jun 27, 2018 · 1 comment
Assignees
@ioannisg
Labels
area: ARM ARM (32-bit) Architecture bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Milestone
v1.13.0

Comments

@galak
Copy link
Collaborator

galak commented Jun 27, 2018

On several of the STM32 platforms the test fails:

./scripts/sanitycheck -p 96b_carbon -s samples/mpu/mem_domain_apis_test/kernel.memory_protection.memory_domains

This is due to the following change:

"arch: arm: mpu: include CMSIS header in arm_mpu.h"
@galak galak added bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug area: ARM ARM (32-bit) Architecture labels Jun 27, 2018
@galak galak added this to the v1.13.0 milestone Jun 27, 2018
@erwango erwango mentioned this issue Jun 28, 2018
Closed
@erwango
Copy link
Member

erwango commented Jun 28, 2018

It is strange this has not been detected by shippable.
Do we know how it happened?

@erwango erwango mentioned this issue Jun 28, 2018
Merged
galak added a commit to galak/zephyr that referenced this issue Jun 28, 2018
@galak
Revert "arch: arm: stm32: correct include issue"
d05b7d4 
This reverts commit 30529da.

We should include SoC headers from HALs before we include
kernel_includes.h.  On ARM this is needed because we tend to get CMSIS
related defines setup by the HAL headers.

Fixes: zephyrproject-rtos#8593

Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
@galak galak closed this as completed in e860775 Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ioannisg ioannisg

Labels
area: ARM ARM (32-bit) Architecture bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Projects
None yet
Milestone
v1.13.0
Development

No branches or pull requests
3 participants
@ioannisg @galak @erwango