dts spi cleanup #11428
Merged
dts spi cleanup #11428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galak
requested review from
andrewboie,
andyross,
erwango,
ioannisg,
jukkar,
MaureenHelm,
nashif,
rgundi and
superna9999
as code owners
Codecov Report
@@ Coverage Diff @@
## master #11428 +/- ##
=======================================
Coverage 48.37% 48.37%
=======================================
Files 265 265
Lines 42192 42192
Branches 10137 10137
=======================================
Hits 20412 20412
Misses 17703 17703
Partials 4077 4077Continue to review full report at Codecov.
|
|
Ok for the STM32 changes |
Using DTS to setup cc2520 SPI settings on quark_se_c1000_devboard. Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
Only the SPI bus for now. Make cc2520's Kconfig aware of DTS on these settings. Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
Now that all SPI controllers support DTS we can remove the Kconfig support for non-DTS options. We also cleanup some defines that should have be DT_MCR20A_ instead of CONFIG_MCR20A_. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
All drivers require DTS for their primary SPI settings. Removing SPI_[0-9]_NAME config option added some more samples changes. Usage of these options there was anyway not relevant. Fixes zephyrproject-rtos#11064 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com> Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
Now that the in tree user of cc2520 uses device tree to configure SPI and GPIO params, we can remove and convert the driver to utilize DT only. This means removing the Kconfig options that come from DT and rename CONFIG_ to DT_ for those options. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
The CC2520 device is specific to the quark_se_c1000_devboard not the intel curie SoC. Move the device node where it belongs. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
galak
force-pushed
the
dts-spi-cleanup
branch
from
7b8bad4
to
6f890a8
Compare
Added support to the ti,cc2520 binding for optional GPIO signals and moved the quark_se_c1000_devboard to define those signals in the DTS. This lets us remove board.h and some #defines & fake Kconfig symbols from the quark_se_c1000_devboard board. Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
galak
force-pushed
the
dts-spi-cleanup
branch
from
6f890a8
to
4476ad3
Compare
nashif
requested changes
Nov 16, 2018
| #define CONFIG_MCR20A_GPIO_IRQ_B_PIN DT_NXP_KINETIS_DSPI_4002C000_NXP_MCR20A_0_IRQB_GPIOS_PIN | ||
| #define CONFIG_MCR20A_GPIO_RESET_NAME DT_NXP_KINETIS_DSPI_4002C000_NXP_MCR20A_0_RESET_GPIOS_CONTROLLER | ||
| #define CONFIG_MCR20A_GPIO_RESET_PIN DT_NXP_KINETIS_DSPI_4002C000_NXP_MCR20A_0_RESET_GPIOS_PIN | ||
| #define DT_IEEE802154_MCR20A_SPI_DRV_NAME DT_NXP_KINETIS_DSPI_4002C000_NXP_MCR20A_0_BUS_NAME |
There was a problem hiding this comment.
should we move those out of the board? frdm_k64f does not have an MCR20A AFAIK.
There was a problem hiding this comment.
Yes, can we do it as a follow up PR. Because soc/arm/nxp_kinetis/kwx/dts_fixup.h also needs addressing.
There was a problem hiding this comment.
soc/arm/nxp_kinetis/kwx/dts_fixup.h
afaik this guy actually has a radio
There was a problem hiding this comment.
Now that you mention it, that sounds familiar.
There was a problem hiding this comment.
Either way, the pull out of MCR20A from the frdm_k64f.dts I'll handle in a followup PR.
There was a problem hiding this comment.
We have issue #7462 for it.
nashif
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in some commits from @tbursztyka and update them a little for various other cleanups related to SPI controllers now all supporting DTS.