Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable STM32WB ADC #17232

Merged
merged 6 commits into from
Jul 31, 2019
Merged

Enable STM32WB ADC #17232

merged 6 commits into from
Jul 31, 2019

Conversation

rickconrey
Copy link

No description provided.

@zephyrbot zephyrbot added area: Devicetree area: ADC Analog-to-Digital Converter (ADC) area: Boards labels Jul 1, 2019
@zephyrbot
Copy link
Collaborator

zephyrbot commented Jul 1, 2019 •
edited
Loading

All checks are passing now.

Review history of this comment for details about previous failed status.
Note that some checks might have not completed yet.

@rickconrey rickconrey requested a review from nashif as a code owner July 1, 2019 23:44
@zephyrbot zephyrbot added the area: Tests Issues related to a particular existing or missing test label Jul 1, 2019
erwango
erwango requested changes Jul 2, 2019
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. Change looks globally good.

Please separate the changes that impacts other series, as well as formatting.
Also, fyi, formatting reference is uncrustify: https://docs.zephyrproject.org/latest/contribute/index.html#uncrustify.

Aim of these requests is to enhance and speed up review process and in the end global code base quality.

drivers/adc/adc_stm32.c Outdated Show resolved Hide resolved
drivers/adc/adc_stm32.c Outdated Show resolved Hide resolved
drivers/adc/adc_stm32.c Outdated Show resolved Hide resolved
drivers/adc/adc_stm32.c Outdated Show resolved Hide resolved
drivers/adc/adc_stm32.c Outdated Show resolved Hide resolved
drivers/adc/adc_stm32.c Outdated Show resolved Hide resolved
drivers/adc/adc_stm32.c Outdated Show resolved Hide resolved
soc/arm/st_stm32/stm32wb/dts_fixup.h Outdated Show resolved Hide resolved
soc/arm/st_stm32/stm32wb/Kconfig.defconfig.series Outdated Show resolved Hide resolved
tests/drivers/adc/adc_api/src/test_adc.c Outdated Show resolved Hide resolved
@erwango erwango added the platform: STM32 ST Micro STM32 label Jul 2, 2019
@erwango
Copy link
Member

erwango commented Jul 2, 2019

@cybertale

@rickconrey rickconrey force-pushed the adc.stm32wb branch 3 times, most recently from 5b3a631 to 06cb152 Compare July 2, 2019 23:17
erwango
erwango requested changes Jul 4, 2019
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comment.
Please also take into account @cybertale proposal.
Then, we'll be fine

drivers/adc/adc_stm32.c Outdated Show resolved Hide resolved
erwango
erwango requested changes Jul 4, 2019
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very last comment.

drivers/adc/adc_stm32.c Outdated Show resolved Hide resolved
@rickconrey rickconrey force-pushed the adc.stm32wb branch 2 times, most recently from c3e7cbc to f1c6548 Compare July 23, 2019 15:09
dbkinder
dbkinder approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@dbkinder dbkinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc changes LGTM.

@erwango erwango requested a review from galak July 24, 2019 07:30
@rickconrey rickconrey force-pushed the adc.stm32wb branch 2 times, most recently from f1eb46d to 5ae2bf0 Compare July 26, 2019 16:06
@witi-manufacturing
drivers: adc: enable ADC on STM32WB
95d8d44 
Enable ADC on STM32WB

Signed-off-by: Rick Conrey <rick.conrey@witiproducts.com>
@witi-manufacturing
drivers: pinmux: enable ADC pins on STM32WB
38899ea 
Enable ADC pins on STM32WB

Signed-off-by: Rick Conrey <rick.conrey@witiproducts.com>
@witi-manufacturing
dts: wb: enable ADC
0aa8c10 
Enable ADC on STM32WB

Signed-off-by: Rick Conrey <rick.conrey@witiproducts.com>
@witi-manufacturing
boards: nucleo_wb55rg: Enable ADC
21ce3c3 
Enable ADC on nucleo_wb55rg

Signed-off-by: Rick Conrey <rick.conrey@witiproducts.com>
@witi-manufacturing
tests: nucleo_wb55rg: add adc test
5d54433 
Add nucleo_wb55rg to ADC test

Signed-off-by: Rick Conrey <rick.conrey@witiproducts.com>
@witi-manufacturing
drivers: adc: Enable ADC on STM32WB
110ce11 
remove legacy define of common ADC instance

Signed-off-by: Rick Conrey <rick.conrey@witiproducts.com>
@galak galak merged commit b8b8d46 into zephyrproject-rtos:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cybertale cybertale cybertale left review comments

@dbkinder dbkinder dbkinder approved these changes

@erwango erwango erwango approved these changes

@rsalveti rsalveti Awaiting requested review from rsalveti

@nashif nashif Awaiting requested review from nashif

@galak galak Awaiting requested review from galak

Assignees
No one assigned
Labels
area: ADC Analog-to-Digital Converter (ADC) area: Boards area: Devicetree area: Tests Issues related to a particular existing or missing test platform: STM32 ST Micro STM32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rickconrey @zephyrbot @erwango @cybertale @dbkinder @galak @witi-manufacturing