-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: usb_dc_nrfx: cleanup #17311
Merged
nashif
merged 5 commits into
zephyrproject-rtos:master
from
jfischer-no:pr-cleanup-usb_dc_nrfx
Jul 5, 2019
Merged
drivers: usb_dc_nrfx: cleanup #17311
nashif
merged 5 commits into
zephyrproject-rtos:master
from
jfischer-no:pr-cleanup-usb_dc_nrfx
Jul 5, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfischer-no
added
area: Drivers
area: USB
Universal Serial Bus
platform: nRF
Nordic nRFx
labels
Jul 3, 2019
finikorg
approved these changes
Jul 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with small comment (not tested)
anangl
requested changes
Jul 4, 2019
Use REQTYPE_GET_DIR and REQTYPE_GET_TYPE macros from USB subsystem instead of specially introduced. Signed-off-by: Johann Fischer <j.fischer@phytec.de>
Fix style issue reported by checkpatch. Signed-off-by: Johann Fischer <j.fischer@phytec.de>
Cleanup around USB_NRFX_EVT_QUEUE_SIZE option. Add value range for USB_NRFX_EVT_QUEUE_SIZE to Kconfig. Signed-off-by: Johann Fischer <j.fischer@phytec.de>
Remove unused EPSTATUS defines. Signed-off-by: Johann Fischer <j.fischer@phytec.de>
Rename EP_BUF_* to EP_BUF_POOL*. Rename MAX_*EP_BUF_SZ to *EP_BUF_MAX_SZ. Signed-off-by: Johann Fischer <j.fischer@phytec.de>
jfischer-no
force-pushed
the
pr-cleanup-usb_dc_nrfx
branch
from
July 4, 2019 21:00
42dc40b
to
6e95a6c
Compare
anangl
approved these changes
Jul 5, 2019
masz-nordic
approved these changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use REQTYPE_GET_DIR and REQTYPE_GET_TYPE macros from
USB subsystem instead of specially introduced.
Fix style issue reported by checkpatch.
Cleanup around USB_NRFX_EVT_QUEUE_SIZE option.
Add value range for USB_NRFX_EVT_QUEUE_SIZE to Kconfig.
Remove unused EPSTATUS defines.
Rename MAX_*EP_BUF_SZ to *EP_BUF_DEFAULT_SZ.