Bluetooth: GATT: Fix segfault discover descriptors all UUIDs #17465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle optional argument UUID in bt_gatt_discover with type DISCOVER_DESCRIPTOR, bt_uuid_cmp doesn't check for NULL pointer. On system with MMU (nrf52_bsim) this can result in segfault. Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
|
Is this something to be back ported to 1.14? |
|
Verified working on nrf52_bsim and nrf52840_pca10056 |
Yes, thank you. |
jhedberg
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle optional argument UUID in bt_gatt_discover with type
DISCOVER_DESCRIPTOR, bt_uuid_cmp doesn't check for NULL pointer.
On system with MMU (nrf52_bsim) this can result in segfault.
Fixes: #16602
Signed-off-by: Joakim Andersson joakim.andersson@nordicsemi.no