Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dts: bindings: Make 'clocks' optional in i2c.yaml #17573

Merged
merged 1 commit into from Jul 17, 2019

Conversation

ulfalizer
Copy link
Collaborator

Setting it seems rare. Maybe it could be changed to required on just
some platforms (!including bindings can change 'optional' to
'required').

Fixes a bunch of errors in
#17532.

Copy link
Collaborator

@galak galak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move 'clocks' into base.yaml as optional and clean. Will submit a PR for that.

@ulfalizer
Copy link
Collaborator Author

@galak
Could do it as a two-step process maybe. Maybe people will discover clock stuff that should get added as a side effect.

Setting it seems rare. Maybe it could be changed to required on just
some platforms (!including bindings can change 'optional' to
'required').

Fixes a bunch of errors in
zephyrproject-rtos#17532.

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
@galak galak merged commit 3b9853d into zephyrproject-rtos:master Jul 17, 2019
@galak galak deleted the i2c-optional-clocks branch July 17, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants