List of missing device tree properties with `category: required` in the binding for the node #17532

ulfalizer · 2019-07-15T15:23:10Z

We want to turn it into an error when a node is missing a property that's listed with category: required in the binding for the node, instead of a warning.

Here's a list of all missing properties now. Please clean it up if you see something you recognize. It was generated by doing a /scripts/sanitycheck -T samples/hello_world --cmake-only -l with the WIP new DT scripts.

The category: required might come from an !included binding. The path is to the top-level binding file.

interrupts not in /soc/i2c@100200 in altera_max10.dts_compiled, req. by dts/bindings/i2c/nios2,i2c.yaml
interrupts not in /soc/uart@201000 in qemu_nios2.dts_compiled, req. by dts/bindings/serial/altera,jtag-uart.yaml
interrupts not in /soc/uart@70001000 in m2gl025_miv.dts_compiled, req. by dts/bindings/serial/microsemi,coreuart.yaml
label not in /pwmleds/blue_pwm_led in hexiwear_k64.dts_compiled, req. by dts/bindings/led/pwm-leds.yaml
label not in /pwmleds/red_pwm_led in nucleo_l496zg.dts_compiled, req. by dts/bindings/led/pwm-leds.yaml
label not in /soc/peripheral@40000000/dtimer@2000 in mps2_an521_nonsecure.dts_compiled, req. by dts/bindings/timer/arm,cmsdk-dtimer.yaml
label not in /soc/peripheral@40000000/timer@10c000 in v2m_musca_b1_nonsecure.dts_compiled, req. by dts/bindings/timer/arm,cmsdk-timer.yaml
label not in /soc/peripheral@50000000/dtimer@2000 in mps2_an521.dts_compiled, req. by dts/bindings/timer/arm,cmsdk-dtimer.yaml
label not in /soc/peripheral@50000000/timer@10c000 in v2m_musca_b1.dts_compiled, req. by dts/bindings/timer/arm,cmsdk-timer.yaml

The text was updated successfully, but these errors were encountered:

ulfalizer · 2019-07-15T15:41:44Z

CC @pabigot @ydamigos @erwango @SavinayDharmappa @jhqian @JunYangNXP

ulfalizer · 2019-07-15T17:24:58Z

Updated the list after fixing a goof in the code that hid some missing required stuff. Galak fixed some stuff too.

The list is sorted now.

I'm guessing STM32 GPIO nodes don't generate interrupts, because I can't find any device tree nodes with 'compatible = "st,stm32-gpio"' and an 'interrupts' property. Remove the required 'interrupts' property from the binding. This fixes a bunch of errors in zephyrproject-rtos#17532. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>

ulfalizer · 2019-07-16T15:44:34Z

There's pending PRs for the clocks stuff now, so removed it.

None of the interrupt controller nodes that use this binding in the device tree files set 'reg' (or have a unit address). Fixes a bunch of errors in zephyrproject-rtos#17532. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>

ulfalizer · 2019-07-16T16:15:51Z

Removed 'reg' (#17578).

ulfalizer · 2019-07-16T17:35:24Z

intmux stuff: #17579

None of the interrupt controller nodes that use this binding in the device tree files set 'reg' (or have a unit address). Fixes a bunch of errors in #17532. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>

Looks like no nodes with bindings that inherit pwm.yaml might be setting 'clocks'. Fixes some errors in zephyrproject-rtos#17532. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>

Setting it seems rare. Maybe it could be changed to required on just some platforms (!including bindings can change 'optional' to 'required'). Fixes a bunch of errors in #17532. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>

Looks like no nodes with bindings that inherit pwm.yaml might be setting 'clocks'. Fixes some errors in #17532. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>

These bindings !include adc.yaml, but their device tree nodes never set 'clocks': dts/bindings/iio/adc/atmel,sam-afec.yaml dts/bindings/iio/adc/atmel,sam0-adc.yaml dts/bindings/iio/adc/nordic,nrf-adc.yaml dts/bindings/iio/adc/nordic,nrf-saadc.yaml The nodes for these bindings do set it (think it's consistent for st,stm32-adc.yaml): dts/bindings/iio/adc/nxp,kinetis-adc12.yaml dts/bindings/iio/adc/st,stm32-adc.yaml Make 'clocks' optional in adc.yaml. Maybe it should be changed to required on some platforms (!including bindings can change 'optional' to 'required'). Fixes a bunch of errors in #17532. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>

These bindings override the 'category: optional' for 'clocks' from uart.yaml with 'category: required', but none of the nodes that use the bindings set 'clocks'. Maybe it's a copy-paste error. Remove the 'clock' overrides. Fixes some errors in #17532. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>

spi-max-frequency is marked as required in dts/bindings/mtd/jedec,spi-nor.yaml. I took the value from the datasheets (133 MHz for all), and guessed that a dummy entry is fine for QEMU. Fixes some errors in zephyrproject-rtos#17532. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>

…essage Use a format that's easier to tweak for pasting into zephyrproject-rtos#17532.

I'm guessing STM32 GPIO nodes don't generate interrupts, because I can't find any device tree nodes with 'compatible = "st,stm32-gpio"' and an 'interrupts' property. Remove the required 'interrupts' property from the binding. This fixes a bunch of errors in zephyrproject-rtos#17532. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>

spi-max-frequency is marked as required in dts/bindings/mtd/jedec,spi-nor.yaml. I took the value from the datasheets (133 MHz for all), and guessed that a dummy entry is fine for QEMU. Fixes some errors in zephyrproject-rtos#17532. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>

spi-max-frequency is marked as required in dts/bindings/mtd/jedec,spi-nor.yaml. I took the value from the datasheets (133 MHz for all), and guessed that a dummy entry is fine for QEMU. Fixes some errors in #17532. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>

I'm guessing STM32 GPIO nodes don't generate interrupts, because I can't find any device tree nodes with 'compatible = "st,stm32-gpio"' and an 'interrupts' property. Remove the required 'interrupts' property from the binding. This fixes a bunch of errors in #17532. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>

spi-max-frequency is marked as required in dts/bindings/mtd/jedec,spi-nor.yaml. I took the value from the datasheets (133 MHz for all), and guessed that a dummy entry is fine for QEMU. Fixes some errors in zephyrproject-rtos#17532. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>

I'm guessing STM32 GPIO nodes don't generate interrupts, because I can't find any device tree nodes with 'compatible = "st,stm32-gpio"' and an 'interrupts' property. Remove the required 'interrupts' property from the binding. This fixes a bunch of errors in zephyrproject-rtos#17532. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>

ulfalizer added the bug The issue is a bug, or the PR is fixing a bug label Jul 15, 2019

ulfalizer changed the title ~~List of missing properties in nodes with category: required in their binding~~ List of missing device tree properties with category: required in the binding for the node Jul 15, 2019

ulfalizer added the area: Devicetree label Jul 15, 2019

vanwinkeljan mentioned this issue Jul 15, 2019

Added dummy current-speed entry for uart0 to native_posix DTS #17542

Merged

ulfalizer mentioned this issue Jul 16, 2019

dts: bindings: Do not require 'interrupts' on STM32 GPIO nodes #17570

Merged

ulfalizer mentioned this issue Jul 16, 2019

dts: bindings: Make 'clocks' optional in adc.yaml #17572

Merged

ulfalizer mentioned this issue Jul 16, 2019

dts: bindings: Make 'clocks' optional in i2c.yaml #17573

Merged

ulfalizer mentioned this issue Jul 16, 2019

dts: bindings: Make 'clocks' optional in pwm.yaml #17574

Merged

ulfalizer mentioned this issue Jul 16, 2019

dts: bindings: Make 'clocks' optional in nxp,{imx-uart,lpc-usart}.yaml #17577

Merged

ulfalizer mentioned this issue Jul 16, 2019

dts: bindings: Do not require a 'reg' property for snps,arcv2-intc #17578

Merged

ulfalizer mentioned this issue Jul 16, 2019

dts: Add missing spi-max-frequency for mimxrt/nxp/hifive1/qemu_riscv2 #17582

Merged

galak pushed a commit that referenced this issue Jul 17, 2019

dts: bindings: Make 'clocks' optional in pwm.yaml

9d02aa0

Looks like no nodes with bindings that inherit pwm.yaml might be setting 'clocks'. Fixes some errors in #17532. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>

ulfalizer added a commit to ulfalizer/zephyr that referenced this issue Jul 18, 2019

Change missing-required back to an error and temporarily change the m…

e20b157

…essage Use a format that's easier to tweak for pasting into zephyrproject-rtos#17532.

ioannisg assigned galak Jul 30, 2019

ulfalizer closed this as completed Jul 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

List of missing device tree properties with `category: required` in the binding for the node #17532

List of missing device tree properties with `category: required` in the binding for the node #17532

ulfalizer commented Jul 15, 2019 •

edited

Loading

ulfalizer commented Jul 15, 2019 •

edited

Loading

ulfalizer commented Jul 15, 2019 •

edited

Loading

ulfalizer commented Jul 16, 2019

ulfalizer commented Jul 16, 2019

ulfalizer commented Jul 16, 2019

List of missing device tree properties with category: required in the binding for the node #17532

List of missing device tree properties with category: required in the binding for the node #17532

Comments

ulfalizer commented Jul 15, 2019 • edited Loading

ulfalizer commented Jul 15, 2019 • edited Loading

ulfalizer commented Jul 15, 2019 • edited Loading

ulfalizer commented Jul 16, 2019

ulfalizer commented Jul 16, 2019

ulfalizer commented Jul 16, 2019

List of missing device tree properties with `category: required` in the binding for the node #17532

List of missing device tree properties with `category: required` in the binding for the node #17532

ulfalizer commented Jul 15, 2019 •

edited

Loading

ulfalizer commented Jul 15, 2019 •

edited

Loading

ulfalizer commented Jul 15, 2019 •

edited

Loading