dts: Add missing spi-max-frequency for mimxrt/nxp/hifive1/qemu_riscv2 #17582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulfalizer
requested review from
kgugala,
MaureenHelm,
nategraff-sifive and
pgielda
as code owners
|
This could be completely wrong, so please check. |
ulfalizer
changed the title
galak
requested changes
Jul 17, 2019
spi-max-frequency is marked as required in dts/bindings/mtd/jedec,spi-nor.yaml. I took the value from the datasheets (133 MHz for all), and guessed that a dummy entry is fine for QEMU. Fixes some errors in zephyrproject-rtos#17532. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
ulfalizer
force-pushed
the
missing-spi-max-freq
branch
from
9a618c2
to
a542a1c
Compare
|
@galak |
ulfalizer
changed the title
galak
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spi-max-frequency is marked as required in
dts/bindings/mtd/jedec,spi-nor.yaml.
I took the value from the datasheets (133 MHz for all), and guessed that
a dummy entry is fine for QEMU.
Fixes some errors in
#17532.