Enable imxrt1010 #19335

jhqian · 2019-09-24T01:22:10Z

Add board support for mimxrt1010_evk

Add board specific pinmux, doc and dts.
Tested with hello_world, synchronization, philosophers, basic/blinky and basic/button. Since no public support from Segger yet, ITCM is set for default code location.
Updated GPIO driver to fit RT1010 on which only 1 IRQ is available for GPIO2 and GPIO5

zephyrbot · 2019-09-24T01:29:36Z

All checks are passing now.

checkpatch (informational only, not a failure)

-:321: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "nxp,mimxrt1010" appears un-documented -- check ./dts/bindings/
#321: FILE: boards/arm/mimxrt1010_evk/mimxrt1010_evk.dts:13:
+	compatible = "nxp,mimxrt1010";

-:360: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string "adesto,at25sf128a" appears un-documented -- check ./dts/bindings/
#360: FILE: boards/arm/mimxrt1010_evk/mimxrt1010_evk.dts:52:
+		compatible = "adesto,at25sf128a", "jedec,spi-nor";

-:360: WARNING:UNDOCUMENTED_DT_STRING: DT compatible string vendor "adesto" appears un-documented -- check ./dts/bindings/vendor-prefixes.txt
#360: FILE: boards/arm/mimxrt1010_evk/mimxrt1010_evk.dts:52:
+		compatible = "adesto,at25sf128a", "jedec,spi-nor";

-:841: WARNING:LONG_LINE: line over 80 characters
#841: FILE: soc/arm/nxp_imx/rt/soc.c:52:
+#if defined(CONFIG_SOC_MIMXRT1021) || defined(CONFIG_SOC_MIMXRT1015) || defined(CONFIG_SOC_MIMXRT1011)

- total: 0 errors, 4 warnings, 758 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

MaureenHelm

Thanks @jhqian

Please update west.yml similar to dd783fe to pull the the changes from zephyrproject-rtos/hal_nxp#13. This will help fix the shippable failure.

MaureenHelm · 2019-09-25T01:23:56Z

soc/arm/nxp_imx/rt/Kconfig.soc

@@ -263,6 +291,9 @@ config INIT_USB1_PLL
 config INIT_VIDEO_PLL
 	bool "Initialize Video PLL"

+config HAS_NO_ARM_DIV


Let's make this positive logic instead. Change to HAS_ARM_DIV, set default y here (since that is the typical case for most socs in this series), then override the default in Kconfig.defconfig.mimxrt1010 only

Thanks, updated as suggested.

MaureenHelm · 2019-09-25T01:25:24Z

soc/arm/nxp_imx/rt/soc.c

@@ -145,7 +146,9 @@ static ALWAYS_INLINE void clkInit(void)
 	CLOCK_InitVideoPll(&videoPllConfig);
 #endif

+#ifndef CONFIG_HAS_NO_ARM_DIV


#ifdef CONFIG_HAS_ARM_DIV

MaureenHelm · 2019-09-25T18:59:48Z

soc/arm/nxp_imx/rt/Kconfig.soc

@@ -263,6 +290,10 @@ config INIT_USB1_PLL
 config INIT_VIDEO_PLL
 	bool "Initialize Video PLL"

+config HAS_ARM_DIV
+	bool "Has the divider for ARM"
+    default y


Replace the leading spaces with a tab

MaureenHelm · 2019-09-25T20:26:52Z

boards/arm/mimxrt1010_evk/mimxrt1010_evk.yaml

+  - gnuarmemb
+  - xtools
+ram: 32
+flash: 16384


Make this 32. This should help resolve the shippable failures

Sure, thanks.

MaureenHelm · 2019-10-16T19:57:57Z

Please address the shippable and documentation failures

jhqian · 2019-11-14T00:34:33Z

Although there's no Segger public support yet, switch to use external flash as code memory rather than tiny TCM.

mnkp · 2019-11-14T08:05:59Z

The merge window for 2.1 is now closed so this PR should target topic-gpio branch where all the boards are converted to use the new API. In case of this PR the required modification is minimal. Only boards/arm/mimxrt1010_evk/mimxrt1010_evk.dts file needs to be updated to use the new GPIO_ACTIVE_LOW flag.

pabigot · 2019-11-14T11:25:12Z

The merge window for 2.1 is now closed so this PR should target topic-gpio branch where all the boards are converted to use the new API

I don't think that's what we agreed. New GPIO drivers must be developed to match the new GPIO API, based on an the expectation that the new API will be merged in the 2.2 window.

We should not be blocking the addition of boards until the new GPIO infrastructure is ready for master, just because they happen to touch a GPIO driver.

jhqian · 2019-11-20T13:00:24Z

Anybody can tell me how I can trigger another shippable check? I just updated the module for NXP hal.

Thanks in advance.

microbuilder · 2019-12-07T22:04:30Z

It looks like this is passing now. I guess the only think preventing it being merged is the 2.1 release?

agansari · 2019-12-16T14:38:17Z

boards/arm/mimxrt1010_evk/board.cmake

+  board_set_flasher_ifnset(jlink)
+endif()
+
+board_runner_args(jlink "--device=cortex-m7")


Please check JLink V6.60

DLL: Added debug support for NXPx iMXRT1010 family (e.g. MIMXRT1011CAE4A)

jhqian · 2020-01-08T03:18:07Z

Is there anything blocking this patch being merged?

MaureenHelm · 2020-01-09T00:04:28Z

soc/arm/nxp_imx/rt/Kconfig.soc

+		FlexSPI configuration block consists of parameters regarding specific
+		flash devices including read command sequence, quad mode enablement
+		sequence (optional), etc. The boot ROM expectes FlexSPI configuration
+		parameter to be presented in serail nor flash.


Please adjust the alignment such that it is indented two spaces more than the help line.

MaureenHelm · 2020-01-09T00:06:15Z

soc/arm/nxp_imx/rt/dts_fixup.h

+#define DT_MCUX_IGPIO_5_IRQ_0			DT_NXP_IMX_GPIO_400C0000_IRQ_0
+#define DT_MCUX_IGPIO_5_IRQ_0_PRI	DT_NXP_IMX_GPIO_400C0000_IRQ_0_PRIORITY
+#define DT_MCUX_IGPIO_5_IRQ_1			DT_NXP_IMX_GPIO_400C0000_IRQ_1
+#define DT_MCUX_IGPIO_5_IRQ_1_PRI	DT_NXP_IMX_GPIO_400C0000_IRQ_1_PRIORITY


Why are you adding IGPIO_5 again? These lines appear to be duplicates

- Check presence of GPIO IRQ related macros before enabling IRQ Signed-off-by: Ryan QIAN <jianghao.qian@nxp.com>

- Add device support for i.MXRT1010 Signed-off-by: Ryan QIAN <jianghao.qian@nxp.com>

Add board support files for mimxrt1010_evk, the development board for i.MXRT1010 (CM7) SoC. - Add pinmux, dts and doc. - Tested samples: hello_world, philosophers, synchronization, basic/blinky, basic/button. Signed-off-by: Ryan QIAN <jianghao.qian@nxp.com>

- extend usb device support for mimxrt1010_evk Signed-off-by: Ryan QIAN <jianghao.qian@nxp.com>

- to get the update hal_nxp from PR #13 Signed-off-by: Ryan QIAN <jianghao.qian@nxp.com>

jhqian requested review from dbkinder, MaureenHelm and MeganHansen as code owners September 24, 2019 01:22

zephyrbot added area: Devicetree area: Boards labels Sep 24, 2019

jhqian force-pushed the enable_imxrt1010 branch 3 times, most recently from e9f3e54 to 2bea616 Compare September 24, 2019 01:45

dbkinder approved these changes Sep 24, 2019

View reviewed changes

MaureenHelm requested changes Sep 25, 2019

View reviewed changes

MaureenHelm requested review from agansari and dleach02 September 25, 2019 01:30

jhqian force-pushed the enable_imxrt1010 branch from 2bea616 to c03c2c6 Compare September 25, 2019 01:51

zephyrbot added the area: Modules label Sep 25, 2019

agansari approved these changes Sep 25, 2019

View reviewed changes

MaureenHelm requested changes Sep 25, 2019

View reviewed changes

jhqian force-pushed the enable_imxrt1010 branch 2 times, most recently from c272c5b to 019fcd6 Compare September 26, 2019 23:15

jhqian force-pushed the enable_imxrt1010 branch 2 times, most recently from 289ce24 to e13bc71 Compare October 10, 2019 05:46

jhqian requested review from andrewboie, andyross, ioannisg, jakub-uC, jukkar, nashif, nordic-krch and pabigot as code owners October 17, 2019 01:06

jhqian force-pushed the enable_imxrt1010 branch 4 times, most recently from 9eaa8ee to e000ac1 Compare November 20, 2019 05:03

agansari suggested changes Dec 16, 2019

View reviewed changes

jhqian force-pushed the enable_imxrt1010 branch from e000ac1 to aa1d329 Compare December 20, 2019 02:49

jhqian requested a review from galak as a code owner December 20, 2019 02:49

jhqian force-pushed the enable_imxrt1010 branch from aa1d329 to 4604b3e Compare December 20, 2019 03:21

zephyrbot added the area: API Changes to public APIs label Dec 20, 2019

agansari approved these changes Dec 20, 2019

View reviewed changes

jhqian force-pushed the enable_imxrt1010 branch from 4604b3e to f4fcf45 Compare December 23, 2019 03:58

zephyrbot closed this Jan 3, 2020

zephyrbot reopened this Jan 3, 2020

MaureenHelm requested changes Jan 9, 2020

View reviewed changes

jhqian added 4 commits January 9, 2020 09:37

driver: gpio: gpio_mcux_igpio: check presence of IRQ macro first

04ec8c1

- Check presence of GPIO IRQ related macros before enabling IRQ Signed-off-by: Ryan QIAN <jianghao.qian@nxp.com>

soc: arm: nxp_imx: rt: add device support i.MX RT1010

b374f73

- Add device support for i.MXRT1010 Signed-off-by: Ryan QIAN <jianghao.qian@nxp.com>

boards: arm: mimxrt1010_evk: Extend usb device support

e806df0

- extend usb device support for mimxrt1010_evk Signed-off-by: Ryan QIAN <jianghao.qian@nxp.com>

jhqian force-pushed the enable_imxrt1010 branch from f4fcf45 to 1706602 Compare January 9, 2020 01:38

west: update the head of hal_nxp

c7e50df

- to get the update hal_nxp from PR #13 Signed-off-by: Ryan QIAN <jianghao.qian@nxp.com>

MaureenHelm force-pushed the enable_imxrt1010 branch from 1706602 to c7e50df Compare January 9, 2020 14:38

MaureenHelm approved these changes Jan 9, 2020

View reviewed changes

MaureenHelm merged commit b4d774a into zephyrproject-rtos:master Jan 9, 2020

MaureenHelm deleted the enable_imxrt1010 branch January 9, 2020 22:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable imxrt1010 #19335

Enable imxrt1010 #19335

jhqian commented Sep 24, 2019

zephyrbot commented Sep 24, 2019 •

edited

Loading

MaureenHelm left a comment •

edited

Loading

MaureenHelm Sep 25, 2019

jhqian Sep 25, 2019

MaureenHelm Sep 25, 2019

MaureenHelm Sep 25, 2019

jhqian Sep 26, 2019

MaureenHelm Sep 25, 2019

jhqian Sep 26, 2019

MaureenHelm commented Oct 16, 2019

jhqian commented Nov 14, 2019

mnkp commented Nov 14, 2019

pabigot commented Nov 14, 2019

jhqian commented Nov 20, 2019

microbuilder commented Dec 7, 2019

agansari Dec 16, 2019

jhqian commented Jan 8, 2020

MaureenHelm Jan 9, 2020

jhqian Jan 9, 2020

MaureenHelm Jan 9, 2020

jhqian Jan 9, 2020

Enable imxrt1010 #19335

Enable imxrt1010 #19335

Conversation

jhqian commented Sep 24, 2019

zephyrbot commented Sep 24, 2019 • edited Loading

checkpatch (informational only, not a failure)

MaureenHelm left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MaureenHelm commented Oct 16, 2019

jhqian commented Nov 14, 2019

mnkp commented Nov 14, 2019

pabigot commented Nov 14, 2019

jhqian commented Nov 20, 2019

microbuilder commented Dec 7, 2019

Choose a reason for hiding this comment

jhqian commented Jan 8, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zephyrbot commented Sep 24, 2019 •

edited

Loading

MaureenHelm left a comment •

edited

Loading