sanitycheck: support 'skipped' in 'passed' field in sanitycheck.csv #22950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the passed field is either 'True' or 'False'. However when we run tests we also have the option of skipping tests for various reasons. Currently we treat 'skipped' tests as 'True'. There are a few cases in which we load sanitycheck.csv to determine which tests to run: 1. --only-failed 2. --load-tests 3. --test-only For the --test-only case the fact that we don't track 'skipped' ends up causing usage errors. One would expect the following to be equivalent: sanitycheck -p qemu_cortex_m0 -T samples/ vs sanitycheck --build-only -p qemu_cortex_m0 -T samples/ sanitycheck --test-only -p qemu_cortex_m0 -T samples/ But the second will fail in --test-only since various jobs that are meant to be skipped are re-tried. So we can easily fix the situation by adding 'skipped' as an option in the 'passed' field in the csv. We change --only-failed to load tests based on the 'passed' field being 'False'. We change --load-tests and --test-only to skip tests with the passed field being 'skipped'. Fixes zephyrproject-rtos#22948 Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
galak
added
area: Sanitycheck
nashif
requested changes
Feb 19, 2020
| @@ -2688,6 +2688,8 @@ class TestSuite: | |||
| for row in cr: | |||
| if row["arch"] == "arch": | |||
| continue | |||
| if row["passed"] == "skipped": | |||
There was a problem hiding this comment.
it is not a good idea to have boolean values mixed with literals. I do not like the binary column called passed, I'd rather change this column completely and call it status (we have that already) and put the right status in it. Let me spend some time and clean this up for real. I thought I fixed this already, because it did annoy me at some point, seems like I missed it.
There was a problem hiding this comment.
Sounds good. I'd prefer to rename the field to status as well!
|
Fix available in #23374 |
|
closing, obsoleted by #23374 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the passed field is either 'True' or 'False'. However when we
run tests we also have the option of skipping tests for various reasons.
Currently we treat 'skipped' tests as 'True'.
There are a few cases in which we load sanitycheck.csv to determine
which tests to run:
For the --test-only case the fact that we don't track 'skipped' ends up
causing usage errors. One would expect the following to be equivalent:
sanitycheck -p qemu_cortex_m0 -T samples/
vs
sanitycheck --build-only -p qemu_cortex_m0 -T samples/
sanitycheck --test-only -p qemu_cortex_m0 -T samples/
But the second will fail in --test-only since various jobs that are
meant to be skipped are re-tried.
So we can easily fix the situation by adding 'skipped' as an option in
the 'passed' field in the csv. We change --only-failed to load tests
based on the 'passed' field being 'False'. We change --load-tests and
--test-only to skip tests with the passed field being 'skipped'.
Fixes #22948
Signed-off-by: Kumar Gala kumar.gala@linaro.org