Sanitycheck: Support --test-only after --build-only #23374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
We used the column 'passed' as a boolean to signify pass or fail, however we do have other states that need to be tracked. Remove the boolean and use a text field instead that has the status as a string. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Merge two functions loading previous results into one and support filtering based on status. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
|
@galak please try this one. |
nashif
requested review from
andrewboie,
carlescufi,
dcpleung,
ioannisg and
MaureenHelm
dcpleung
approved these changes
Mar 24, 2020
carlescufi
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support the following operation mode:
sanitycheck --build-only -p qemu_cortex_m0 -T samples/
sanitycheck --test-only -p qemu_cortex_m0 -T samples/
The PR fixes filtering of results.
Fixes #22948