Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: uart_async_api: Support atsamr21_xpro board #24610

Merged
merged 1 commit into from
Apr 23, 2020
Merged

tests: uart_async_api: Support atsamr21_xpro board #24610

merged 1 commit into from
Apr 23, 2020

Conversation

stephanosio
Copy link
Member

@stephanosio stephanosio commented Apr 22, 2020 •
edited

This commit adds the asynchronous UART API testing support on the SAM
R21 Xplained Pro board.

The SERCOM3 module is used as the secondary loop-back UART, which is
required to run this test.

Note that no external UART loop-back connection is necessary to run
this test, because the SERCOM3 UART TX and RX pads are configured to be
internally connected; it is, however, still necessary to configure the
pinmux because the module pads are not connected until the pinmux is
configured.

Signed-off-by: Stephanos Ioannidis root@stephanos.io

To be rebased on top of #24572 (blocked by #24572). Done

@stephanosio stephanosio added area: Drivers area: Tests Issues related to a particular existing or missing test area: UART Universal Asynchronous Receiver-Transmitter Blocked Blocked by another PR or issue platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) labels Apr 22, 2020
@stephanosio
Copy link
Member Author

@nandojve Can you test if this works on your SAM R21 Xplained Pro board?

@stephanosio stephanosio force-pushed the test_uart_async_api_samr21 branch 2 times, most recently from 0998778 to c7e321f Compare April 22, 2020 14:53
@stephanosio
Copy link
Member Author

Modified the test to use SERCOM3 on PA22/23 instead of SERCOM2 on PA12/13, since those pins are free and connected to an external connector on the board.

@nandojve
Copy link
Member

Hi @stephanosio, well done!

*** Booting Zephyr OS build zephyr-v2.2.0-1815-ga68a6b0a9b39  ***
Running test suite uart_async_test
===================================================================
starting test - test_single_read_setup
PASS - test_single_read_setup
===================================================================
starting test - test_single_read
PASS - test_single_read
===================================================================
starting test - test_chained_read_setup
PASS - test_chained_read_setup
===================================================================
starting test - test_chained_read
PASS - test_chained_read
===================================================================
starting test - test_double_buffer_setup
PASS - test_double_buffer_setup
===================================================================
starting test - test_double_buffer
PASS - test_double_buffer
===================================================================
starting test - test_read_abort_setup
PASS - test_read_abort_setup
===================================================================
starting test - test_read_abort
PASS - test_read_abort
===================================================================
starting test - test_chained_write_setup
PASS - test_chained_write_setup
===================================================================
starting test - test_chained_write
PASS - test_chained_write
===================================================================
starting test - test_long_buffers_setup
PASS - test_long_buffers_setup
===================================================================
starting test - test_long_buffers
PASS - test_long_buffers
===================================================================
starting test - test_write_abort_setup
PASS - test_write_abort_setup
===================================================================
starting test - test_write_abort
PASS - test_write_abort
===================================================================
starting test - test_forever_timeout_setup
PASS - test_forever_timeout_setup
===================================================================
starting test - test_forever_timeout
PASS - test_forever_timeout
===================================================================
Test suite uart_async_test succeeded
===================================================================
PROJECT EXECUTION SUCCESSFUL

This was referenced Apr 23, 2020
Merged
Closed
@stephanosio
Copy link
Member Author

Rebased

This PR can be merged now.

@stephanosio stephanosio removed the Blocked Blocked by another PR or issue label Apr 23, 2020
@stephanosio stephanosio deleted the test_uart_async_api_samr21 branch April 23, 2020 06:17
@stephanosio stephanosio restored the test_uart_async_api_samr21 branch April 23, 2020 06:17
@stephanosio stephanosio reopened this Apr 23, 2020
@galak
Copy link
Collaborator

galak commented Apr 23, 2020

needs minor rebase since I merged the other PR.

@stephanosio
Copy link
Member Author

needs minor rebase since I merged the other PR.

@galak Rebased

@stephanosio stephanosio reopened this Apr 23, 2020
@stephanosio
tests: uart_async_api: Support atsamr21_xpro board
224e5e8 
This commit adds the asynchronous UART API testing support on the SAM
R21 Xplained Pro board.

The SERCOM3 module is used as the secondary loop-back UART, which is
required to run this test.

Note that no external UART loop-back connection is necessary to run
this test, because the SERCOM3 UART TX and RX pads are configured to be
internally connected; it is, however, still necessary to configure the
pinmux because the module pads are not connected until the pinmux is
configured.

Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
@MaureenHelm MaureenHelm merged commit 547a5e9 into zephyrproject-rtos:master Apr 23, 2020
@stephanosio stephanosio deleted the test_uart_async_api_samr21 branch April 23, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@nandojve nandojve nandojve approved these changes

@galak galak galak approved these changes

@Mierunski Mierunski Awaiting requested review from Mierunski

@benpicco benpicco Awaiting requested review from benpicco

@Sizurka Sizurka Awaiting requested review from Sizurka

Assignees
No one assigned
Labels
area: Boards area: Drivers area: Tests Issues related to a particular existing or missing test area: UART Universal Asynchronous Receiver-Transmitter platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stephanosio @nandojve @galak @MaureenHelm @zephyrbot