stm32h7: Transition clock configuration from Kconfig to device tree #34701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwango
requested review from
ABOSTM,
carlescufi,
FRASTM,
galak,
MaureenHelm and
nashif
as code owners
github-actions
bot
added
area: Boards
area: Devicetree
platform: STM32
FRASTM
changed the title
|
About H7 and clock device tree there any link with the #34691, I mean is it one still valid after "stm32h7: Transition clock configuration from Kconfig to device tree" ? |
The one that gets merged first will need to take the other one into account. |
FRASTM
reviewed
Apr 29, 2021
| compatible = "st,stm32-hse-clock"; | ||
| /* H7 clock driver may not always need this value */ | ||
| /* but it is required by the binding */ | ||
| clock-frequency = <DT_FREQ_M(25)>; |
There was a problem hiding this comment.
why setting 25MHz then ? Even if not used here, most of the stm32h7 have `clock-frequency = <DT_FREQ_M(8)>;``
There was a problem hiding this comment.
25MHz is value of HSE_VALUE provided by Cube HAL
ABOSTM
requested changes
Apr 29, 2021
erwango
force-pushed
the
dev_dt_clocks_h7
branch
from
7b84f08
to
dd2738d
Compare
github-actions
bot
added
area: API
ABOSTM
requested changes
Apr 29, 2021
erwango
force-pushed
the
dev_dt_clocks_h7
branch
from
dd2738d
to
6c338c3
Compare
Fixed, txs |
mbolivar-nordic
approved these changes
Apr 29, 2021
erwango
force-pushed
the
dev_dt_clocks_h7
branch
from
6c338c3
to
40b43dd
Compare
FRASTM
approved these changes
Apr 30, 2021
Add clocks related stm32h7 specific bindings: - stm32h7-hsi-clock - stm32h7-pll-clock - stm32h7-rcc Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
Add clock nodes for stm32h7 devices. Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
Add required macros to introduce dts based clock_control driver configuration on stm32h7 devices. Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
Update stm32h7 clock_control driver to make use of macros allowing dts based configuration in coexistance with existing Kconfig method. Note: Use of IS_ENABLED is removed as it generates warnings in checkpatch. This checkpatch behavior needs to be reviewed but may first require a little clean up of IS_ENABLED macro. Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
Configure board clocks using device tree. Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
Configure board clocks using device tree. Bus clocks configuration part is kept common to both cores. On core dedicated configuration we find: - Specific sysclock freq on both cores - Sysclk input clock selection on M7 core only (as per existing clock_control driver behavior). Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
erwango
force-pushed
the
dev_dt_clocks_h7
branch
from
40b43dd
to
3da4829
Compare
erwango
added a commit
to erwango/zephyr
that referenced
this pull request
May 5, 2021
Following introduction of dts based driver configuration (cf zephyrproject-rtos#34120, zephyrproject-rtos#32609 and zephyrproject-rtos#34701), deprecate Kconfig symbols by generating a warning when one of these symbols is used. Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #34120, convert stm32h7 clock_control driver to the use of device tree for clocks configuration
EDIT:
Includes #34704 to avoid CI related issues