dts: gen_defines: Generate PARTITION_ID only for "okay" nodes #36394
Conversation
The commit modifies how the PARTITION_ID is generated, to provide an ID only for partition nodes that are "okay". The change will cause code trying to obtain ID of non-"okay"ed partition to fail compilation, which allows compile time detection of addressing non-existing partitions. This also allows to produce, at compile time, arrays of objects that can be indexed by the ID of partition, while not including disabled nodes. Signed-off-by: Dominik Ermel <dominik.ermel@nordicsemi.no>
de-nordic
requested review from
carlescufi,
galak,
MaureenHelm,
mbolivar-nordic and
nashif
as code owners
github-actions
bot
added
area: API
| @@ -63,6 +63,9 @@ extern "C" { | |||
|
|
|||
| /** | |||
| * @brief Get a numeric identifier for a fixed partition | |||
| * | |||
| * The partition ID will be only available from status "okay" partition entries | |||
There was a problem hiding this comment.
This is a backwards-incompatible change, and devicetree.h was just marked stable, so this will need to go through the stable API change process now, with an RFC issue, email to devel, etc. etc.
|
No objections to the idea, but we need to follow the stable API process, so adding a DNM until all that boilerplate work is done too. |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
|
@galak please take a look |
So I'd like to see if we could phase out the PARTITION_ID usage from the generation script. We might a new form of |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
The commit modifies how the PARTITION_ID is generated, to provide
an ID only for partition nodes that are "okay".
The change will cause code trying to obtain ID of non-"okay"ed
partition to fail compilation, which allows compile time detection
of addressing non-existing partitions.
This also allows to produce, at compile time, arrays of objects
that can be indexed by the ID of partition, while not including
disabled nodes.
Currently when user defines, for example 80 partitions, and enables only 2, the identifiers for them may be for example 3 and 49, although only two exist within system; these are auto generated from DTS after it has been generated from all DTS overlays, and so on, and is never literally stated within DTS; any change to the DTS may actually give these IDs some other random values.
The commit changes how the IDs are generated so that they are generated starting at 0 and will be numbered in continuous way up to N-1 where N is number of enabled partitions.
This has been taken from #34530
Signed-off-by: Dominik Ermel dominik.ermel@nordicsemi.no