-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: build_all: Add device pm configuration for sensor drivers #39706
Merged
nashif
merged 3 commits into
zephyrproject-rtos:main
from
MaureenHelm:build-all-sensors-pm
Oct 27, 2021
Merged
tests: build_all: Add device pm configuration for sensor drivers #39706
nashif
merged 3 commits into
zephyrproject-rtos:main
from
MaureenHelm:build-all-sensors-pm
Oct 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Devicetree
area: Tests
Issues related to a particular existing or missing test
labels
Oct 25, 2021
gmarull
requested changes
Oct 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the fix for bq274xx should be different though
galak
approved these changes
Oct 25, 2021
teburd
approved these changes
Oct 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, and is clearly already catching build issues
ceolin
approved these changes
Oct 26, 2021
MaureenHelm
force-pushed
the
build-all-sensors-pm
branch
from
October 26, 2021 17:58
ab960c1
to
aadab87
Compare
gmarull
approved these changes
Oct 26, 2021
Fixes a build error in the bq274xx sensor driver when device power management is enabled. Signed-off-by: Maureen Helm <maureen.helm@intel.com>
Fixes a build error in the ina219 sensor driver when device power management is enabled. Signed-off-by: Maureen Helm <maureen.helm@intel.com>
Adds another test configuration to ensure we build sensor drivers with device power management enabled, in addition to the existing test that builds sensor drivers with device power management disabled. Signed-off-by: Maureen Helm <maureen.helm@intel.com>
MaureenHelm
force-pushed
the
build-all-sensors-pm
branch
from
October 26, 2021 23:41
aadab87
to
26fced7
Compare
Rebased to pick up fix in #39742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Devicetree
area: Power Management
area: Sensors
Sensors
area: Tests
Issues related to a particular existing or missing test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds another test configuration to ensure we build sensor drivers with
device power management enabled, in addition to the existing test that
builds sensor drivers with device power management disabled.
Signed-off-by: Maureen Helm maureen.helm@intel.com
Fixes #39721
@ceolin @gmarull I think we need to start doing this for other driver classes (SPI, I2C, etc) too.