Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: build_all: Add device pm configuration for sensor drivers #39706

Merged
merged 3 commits into from
Oct 27, 2021

Conversation

MaureenHelm
Copy link
Member

@MaureenHelm MaureenHelm commented Oct 25, 2021

Adds another test configuration to ensure we build sensor drivers with
device power management enabled, in addition to the existing test that
builds sensor drivers with device power management disabled.

Signed-off-by: Maureen Helm maureen.helm@intel.com

Fixes #39721

@ceolin @gmarull I think we need to start doing this for other driver classes (SPI, I2C, etc) too.

@github-actions github-actions bot added area: Devicetree area: Tests Issues related to a particular existing or missing test labels Oct 25, 2021
Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the fix for bq274xx should be different though

drivers/sensor/bq274xx/bq274xx.h Outdated Show resolved Hide resolved
Copy link
Collaborator

@teburd teburd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, and is clearly already catching build issues

Fixes a build error in the bq274xx sensor driver when device power
management is enabled.

Signed-off-by: Maureen Helm <maureen.helm@intel.com>
Fixes a build error in the ina219 sensor driver when device power
management is enabled.

Signed-off-by: Maureen Helm <maureen.helm@intel.com>
Adds another test configuration to ensure we build sensor drivers with
device power management enabled, in addition to the existing test that
builds sensor drivers with device power management disabled.

Signed-off-by: Maureen Helm <maureen.helm@intel.com>
@MaureenHelm
Copy link
Member Author

Rebased to pick up fix in #39742

@nashif nashif merged commit b88111b into zephyrproject-rtos:main Oct 27, 2021
@MaureenHelm MaureenHelm deleted the build-all-sensors-pm branch October 27, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Devicetree area: Power Management area: Sensors Sensors area: Tests Issues related to a particular existing or missing test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bq274xx sensor - Fails to compile when CONFIG_PM_DEVICE enabled
6 participants