Sensing Subsystem Upstream PR1 #55389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ghu0510
commented
Mar 3, 2023
•
ghu0510
commented
- sensor: Adding Sensor Subsystem API
- doc: Add documents for sensor subsystem (sensing)
- sensing: add sensor subsystem skeleton
- sensing: phy_3d_sensor: add phy_3d_sensor skeleton
- sensing: initial sensor list and enumerate each sensor
- samples: senss: add a simple sensor subsystem app
- MAINTAINERS: Add maintainer and collaborator for Sensing Subsystem
- CODEOWNERS: Add code owners for Sensing Subsystem
ghu0510
requested review from
nashif,
carlescufi,
galak and
MaureenHelm
as code owners
zephyrbot
added
area: Devicetree Binding
yperess
requested changes
Mar 3, 2023
ghu0510
force-pushed
the
ghu_senss_upstream_pr1
branch
2 times, most recently
from
b5aae17
to
af51800
Compare
ghu0510
force-pushed
the
ghu_senss_upstream_pr1
branch
2 times, most recently
from
c09dbea
to
8fbdfaa
Compare
|
Please fix the failed doc check: |
ghu0510
force-pushed
the
ghu_senss_upstream_pr1
branch
from
8fbdfaa
to
3073e90
Compare
Actually, I have modified it in last commit. Anyway, update to latest main branch, and run CI again. |
ghu0510
force-pushed
the
ghu_senss_upstream_pr1
branch
10 times, most recently
from
e18e506
to
6fa62b5
Compare
3 tasks
yperess
dismissed
their stale review
Agreed to file concerns as a separate issue, see #58925
ghu0510
force-pushed
the
ghu_senss_upstream_pr1
branch
2 times, most recently
from
a7d74b0
to
1198dd5
Compare
keith-zephyr
reviewed
Jun 7, 2023
ghu0510
force-pushed
the
ghu_senss_upstream_pr1
branch
from
1198dd5
to
f449e17
Compare
keith-zephyr
previously approved these changes
Jun 8, 2023
teburd
previously approved these changes
Jun 8, 2023
ghu0510
force-pushed
the
ghu_senss_upstream_pr1
branch
from
f449e17
to
189d771
Compare
This API introduced a new sensing subsystem, which is a high level sensor framework inside the OS user space service layer. It's a framework focus on sensor fusion, clients arbitration, sampling, timing, scheduling and sensor based power management. It's key concepts including physical sensor and virtual sensor objects, and a scheduling framework reflects sensor objects' reporting relationship. Physical sensors not depends on any other sensor objects for input, and will directly interact with existing zephyr sensor device drivers. Virtual sensors rely on other sensor objects (physical or virtual) as report inputs. The sensing subsystem relies on existing zephyr sensor device APIs or V2 zephyr sensor device APIs (zephyrproject-rtos#44098). So it can leverage current existing zephyr sensor device drivers (100+). And it's configurable, so, for some low cost IoT devices, may not need an advanced sensor framework, but just need access some simple sensor devices,can not configure and build this sensor subsystem, but just use the exiting zephyr sensor device APIs to save memory resources. Since the sensing subsystem is separated from device driver layer or kernel space and could support various customizations and sensor algorithms in user space with virtual sensor concepts. The existing sensor device driver can focus on low layer device side works, can keep simple as much as possible, just provide device HW abstraction and operations etc. This is very good for system stability. The sensing subsystem is decoupled with any sensor expose/transfer protocols, the target is to support various up-layer frameworks and Applications with different sensor expose/transfer protocols, such as CHRE, HID sensors Applications, MQTT sensor Applications according different products requirements. Or even support multiple Applications with different up-layer sensor protocols at the same time with it's multiple clients support design. For example can support CHRE and other normal zephyr sensor application (can use HID etc) at the same time. Signed-off-by: Hebo Hu <hebo.hu@intel.com> Signed-off-by: Guangfu Hu <guangfu.hu@intel.com>
Add documents for sensing subsystem. Signed-off-by: Hebo Hu <hebo.hu@intel.com>
Add Sensing Subsystem skeleton. Signed-off-by: Guangfu Hu <guangfu.hu@intel.com> Signed-off-by: Zhang Lixu <lixu.zhang@intel.com>
Add the sensor phy_3d_sensor skeleton in Sensing Subsystem. Signed-off-by: Zhang Lixu <lixu.zhang@intel.com>
Implement sensing_init(): 1) create sensors from device tree 2) sequence sensors following node dependency ordering rule generated by Zephyr DTS 3) initial each sensor, includes: a) creating sensor connection between reporter and client, b) calling sensor init callback, c) setting sensor state Implement sensing_open_sensor(): 1) malloc connection from reporter to application 2) bind connection Implement sensing_close_sensr(): 1) unbind connection 2) free connection from reporter to application Implement sensing_set_config(): 1) call set_interval 2) cann set_sensitivity Implement sensing_get_config(): 1) call get_interval 2) call get_sensitivity Signed-off-by: Guangfu Hu <guangfu.hu@intel.com>
Add a simple sensing subsystem application. Signed-off-by: Guangfu Hu <guangfu.hu@intel.com>
Add lixuzha, ghu0510, qianruh as maintainer and collaborators for the Sensing Subsystem. Signed-off-by: Zhang Lixu <lixu.zhang@intel.com>
Add lixuzha, ghu0510, qianruh for the Sensor Subsystem. Signed-off-by: Zhang Lixu <lixu.zhang@intel.com>
teburd
approved these changes
Jun 9, 2023
MaureenHelm
approved these changes
Jun 9, 2023
keith-zephyr
approved these changes
Jun 9, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @ghu0510!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!
To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.
Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁
This was referenced Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.