Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghu sensing upstream pr3 #59469

Closed

Conversation

ghu0510
Copy link
Contributor

@ghu0510 ghu0510 commented Jun 21, 2023

sensing: hinge angle sensor initial
sensing: loop sensors in runtime module
sensing: implement sensor process data function
sensing: implement sleep time calculation for sensor loop
sensing: implement sensor post data processing

@ghu0510 ghu0510 requested a review from galak as a code owner June 21, 2023 09:03
@yperess yperess self-assigned this Jun 22, 2023
@yperess
Copy link
Collaborator

yperess commented Jun 22, 2023

During the review of #55389 it was agreed to unblock it as long as design concerns are addressed before any additional changes are built on top of the subsystem. Please address #58925 first.

@yperess yperess added the DNM This PR should not be merged (Do Not Merge) label Jun 22, 2023
@ghu0510 ghu0510 requested a review from lixuzha as a code owner June 28, 2023 05:27
@zephyrbot zephyrbot added area: Sensor Subsystem area: Devicetree Binding PR modifies or adds a Device Tree binding area: Sensors Sensors labels Jun 28, 2023
@ghu0510 ghu0510 force-pushed the ghu_sensing_upstream_pr3 branch 7 times, most recently from 749cea4 to 719560c Compare June 30, 2023 09:12
1) modify reporter type from int to const sensing_sensor_handle_t in
sensing_sensor_process_t callback
2) move variable shift behind struct sensing_sensor_value_header in
struct sensing_sensor_value_q31
3) add pointer checking for sensing API

Signed-off-by: Guangfu Hu <guangfu.hu@intel.com>
Add hinge angle virtual sensor for sensing subsystem, hinge angle sensor
takes both base accel and lid accel as reporter

Signed-off-by: Guangfu Hu <guangfu.hu@intel.com>
set/get interval sensitivity is implmented in sensor management module,
and also add related test case

Signed-off-by: Guangfu Hu <guangfu.hu@intel.com>
create runtime thread and wait event semphore, meanwhile, trigger event
semphore in set interval/sensitivity API to notify runtime thread to
arbitrate interval/sensitivity

Signed-off-by: Guangfu Hu <guangfu.hu@intel.com>
implement hinge angle sensor init and set interval function

Signed-off-by: Guangfu Hu <guangfu.hu@intel.com>
add runtime module, implement loop sensors in runtime module

Signed-off-by: Guangfu Hu <guangfu.hu@intel.com>
1) enhance sensor need execute function, and data ready and sensor has
new data checking
2) implement sensor process data function, included both physical sensor
and virtual sensor data processing
3) implement sensor send dato to client, including time and sensitivity
checking and update sensor consume time

Signed-off-by: Guangfu Hu <guangfu.hu@intel.com>
implement sleep time calculation in loop sensors

Signed-off-by: Guangfu Hu <guangfu.hu@intel.com>
1) enhance sensor data process, check time, sensitivity condition
2) send data to its client
3) create dispatch thread to process sensor data from runtime module

Signed-off-by: Guangfu Hu <guangfu.hu@intel.com>
@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Aug 30, 2023
@github-actions github-actions bot closed this Sep 13, 2023
@lixuzha
Copy link
Collaborator

lixuzha commented Nov 27, 2023

Basing on design changed, submit #64478 to instead of this one. Closed this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: Sensor Subsystem area: Sensors Sensors DNM This PR should not be merged (Do Not Merge) Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants