boards: shields: add rk055hdmipi4m shield definition #55493

danieldegrasse · 2023-03-06T17:35:15Z

~~Note- the PR depends on #53907, and contains commits from it. Those commits will be dropped once that PR merges~~

Add rk055hdmipi4m shield definition. This shield contains a 1280x720
display driven by an RM68200 IC, with a GT911 touch controller. The
display is supported by a 40 pin FFC connector present on NXP's RT1170
and RT595 EVKs.

boards/shields/rk055hdmipi4m/Kconfig.defconfig

erwango · 2023-05-12T07:00:34Z

boards/shields/rk055hdmipi4m/Kconfig.defconfig

+config DISPLAY
+	default y


This should be set at application level, not as part of default configuration.
Same policy used in boards apply here.

@danieldegrasse This does not seem to be addressed.

danieldegrasse · 2023-05-12T14:22:18Z

@erwango Thank you for taking a look- requested changes should be addressed

jfischer-no · 2023-05-15T14:58:24Z

boards/shields/rk055hdmipi4m/rk055hdmipi4m.overlay

+	backlight-gpios = <&mipi_connector 0 GPIO_ACTIVE_HIGH>;
+};
+
+&mipi_dsi {


https://docs.zephyrproject.org/latest/hardware/porting/shields.html#board-compatibility, do we consider mipi_dsi to be well-known connector? Should it not be zephyr_mipi_dsi?

mipi_dsi is the node definition being used for shields that currently define mipi displays: https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/shields/st_b_lcd40_dsi1_mb1166/st_b_lcd40_dsi1_mb1166.overlay. Since we have a MIPI-DSI API, I think it is fair to define this nodelabel as a well known connector.

The alternative here would be to provide no shield overlay, and only board specific overlays within the shield, since the connection between these displays and the EVK does not use the Arduino headers, and is made via a 40 pin flat flexible cable. I think that defining this cable's pins as a GPIO nexus makes sense though, as the interface is shared between multiple NXP EVKs, and defining the shield this way allows more reuse than board specific overlays

The alternative here would be to provide no shield overlay, and only board specific overlays within the shield, since the connection between these displays and the EVK does not use the Arduino headers, and is made via a 40 pin flat flexible cable. I think that defining this cable's pins as a GPIO nexus makes sense though, as the interface is shared between multiple NXP EVKs, and defining the shield this way allows more reuse than board specific overlays

I know that it does not use Arduino headers or other well-known connectors. But IMO mipi_dsi is too SoC specific, there could be mipi_dsi0 and mipi_dsiX, therefore I think it make sense to use zephyr_mipi_dsi nodelabel at the board level as reference to default interface, like we do it using zephyr_udc0.

Ok, I'm fine using that. We should do the same to the LCD controller, since the bindings for that are also generic with #53907

Do these node labels look ok to you?
zephyr_lcdif- for LCD interface controller
zephyr_mipi_dsi- for MIPI DSI controller
nxp_mipi_connector- for 40 pin connector (present on NXP EVKs, but any board could implement this)
nxp_mipi_i2c- for I2C interface exposed on the mipi connector. Used with the touch controller.

@jfischer-no ping- do these names look good to you?

Ok, I'm fine using that. We should do the same to the LCD controller, since the bindings for that are also generic with #53907

Do these node labels look ok to you? zephyr_lcdif- for LCD interface controller zephyr_mipi_dsi- for MIPI DSI controller

LGTM, not sure if you need to prefix lcdif if it is referenced by mipi dsi node. @erwango ?

LGTM, not sure if you need to prefix lcdif if it is referenced by mipi dsi node. @erwango ?

TBH, I think I'm missing some background on this topic, so looks fine to me.

The display pipeline here works as follows:

LCDIF writes DPI packets to MIPI, which serializes those packets as DSI data and sends them to the RK055HDMIPI4M. This allows the display to be constantly refreshed, which is required as this is a video mode display. I believe this same pipeline is possible on ST devices using the LTDC and the MIPI-DSI. The only property here that is NXP specific is the nxp,lcdif. This is used by our MIPI driver to extract LCD configuration parameters, and avoids the display controller having to redeclare these parameters when using the mipi_dsi_attach function.

boards/shields/rk055hdmipi4m/Kconfig.defconfig

erwango · 2023-06-14T09:38:15Z

boards/shields/rk055hdmipi4m/Kconfig.defconfig

+config DISPLAY
+	default y


danieldegrasse · 2023-06-22T14:05:57Z

@erwango @jfischer-no ping- can you revisit this PR?

Add rk055hdmipi4m shield definition. This shield contains a 1080x720 display driven by an RM68200 IC, with a GT911 touch controller. The display is supported by a 40 pin FFC connector present on NXP's RT1170 and RT595 EVKs. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>

Remove display definition from RT1170 EVK, as this can now be handled via a shield. Add gpio nexus defining GPIO routing to the FFC connector. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>

Remove display definition from RT595 EVK, as this is now supported by the shield. Add gpio nexus for the FFC connector on this EVK. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>

Enable logging by default in kscan sample, so that user will see output even if they do not have a keyboard connected that follows the keymap. Add a specific testcase for boards that support the RK055HDMIPI4M display. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>

Add a specific testcase for boards that support the RK055HDMIPI4M display. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>

erwango

Late minute question

samples/drivers/kscan/sample.yaml

danieldegrasse force-pushed the feature/rm68200_shield branch 2 times, most recently from 2795083 to 88c3983 Compare March 6, 2023 23:10

danieldegrasse force-pushed the feature/rm68200_shield branch 2 times, most recently from 825f625 to 60f2fd7 Compare March 15, 2023 19:36

danieldegrasse force-pushed the feature/rm68200_shield branch 2 times, most recently from 13cb9ec to 9d5d918 Compare May 4, 2023 19:01

This was referenced May 5, 2023

drivers: display: introduce G1120B0MIPI watch display #57578

Merged

drivers: dma: add SMARTDMA driver, and enable on G1120B0 display #57616

Merged

danieldegrasse force-pushed the feature/rm68200_shield branch from 9d5d918 to ff67062 Compare May 11, 2023 17:52

danieldegrasse marked this pull request as ready for review May 11, 2023 20:32

danieldegrasse requested review from nashif, erwango, mmahadevan108 and dleach02 as code owners May 11, 2023 20:32

zephyrbot added area: Kscan platform: NXP NXP area: Shields Shields (add-on boards) labels May 11, 2023

zephyrbot requested review from albertofloyd, avisconti, dbaluta, decsny, DerekSnell, EmilioCBen, iuliana-prodan, jfischer-no, manuargue, VenkatKotakonda and yvanderv May 11, 2023 20:32

zephyrbot assigned dleach02 May 11, 2023

erwango requested changes May 12, 2023

View reviewed changes

danieldegrasse force-pushed the feature/rm68200_shield branch from ff67062 to 498d6af Compare May 12, 2023 14:21

erwango previously approved these changes May 15, 2023

View reviewed changes

danieldegrasse dismissed erwango’s stale review via fb67ead May 15, 2023 14:40

danieldegrasse force-pushed the feature/rm68200_shield branch from 498d6af to fb67ead Compare May 15, 2023 14:40

jfischer-no requested changes May 15, 2023

View reviewed changes

danieldegrasse force-pushed the feature/rm68200_shield branch from fb67ead to 3869ca7 Compare May 16, 2023 22:03

danieldegrasse requested a review from jfischer-no May 18, 2023 16:22

dleach02 requested a review from erwango June 13, 2023 23:02

erwango requested changes Jun 14, 2023

View reviewed changes

danieldegrasse force-pushed the feature/rm68200_shield branch from 3869ca7 to dab7c76 Compare June 14, 2023 13:54

danieldegrasse added 5 commits July 3, 2023 13:14

boards: arm: mimxrt1170_evk: remove RK055HDMIPI4M display definition

ec72aee

Remove display definition from RT1170 EVK, as this can now be handled via a shield. Add gpio nexus defining GPIO routing to the FFC connector. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>

boards: arm: mimxrt595_evk: remove RK055HDMIPI4M display definition

5a114bf

Remove display definition from RT595 EVK, as this is now supported by the shield. Add gpio nexus for the FFC connector on this EVK. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>

tests: drivers: kscan: add RK055HDMIPI4M shield

91d52af

Add a specific testcase for boards that support the RK055HDMIPI4M display. Signed-off-by: Daniel DeGrasse <daniel.degrasse@nxp.com>

danieldegrasse force-pushed the feature/rm68200_shield branch from dab7c76 to 91d52af Compare July 3, 2023 18:23

jfischer-no approved these changes Jul 4, 2023

View reviewed changes

danieldegrasse requested a review from erwango July 4, 2023 17:42

erwango approved these changes Jul 6, 2023

View reviewed changes

erwango requested changes Jul 6, 2023

View reviewed changes

samples/drivers/kscan/sample.yaml Show resolved Hide resolved

danieldegrasse mentioned this pull request Jul 8, 2023

boards: shields: add rk055hdmipi4ma0 shield definition #60174

Merged

danieldegrasse requested a review from erwango July 10, 2023 14:22

erwango approved these changes Jul 11, 2023

View reviewed changes

dleach02 merged commit 40849e4 into zephyrproject-rtos:main Jul 11, 2023
19 checks passed

danieldegrasse deleted the feature/rm68200_shield branch July 11, 2023 14:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

boards: shields: add rk055hdmipi4m shield definition #55493

boards: shields: add rk055hdmipi4m shield definition #55493

danieldegrasse commented Mar 6, 2023 •

edited

erwango May 12, 2023

jfischer-no May 24, 2023

erwango Jun 14, 2023

danieldegrasse commented May 12, 2023

jfischer-no May 15, 2023

danieldegrasse May 15, 2023

jfischer-no May 15, 2023

danieldegrasse May 15, 2023 •

edited

danieldegrasse May 16, 2023

jfischer-no May 24, 2023

erwango Jun 14, 2023

danieldegrasse Jun 14, 2023

erwango Jun 14, 2023

danieldegrasse commented Jun 22, 2023

erwango left a comment

boards: shields: add rk055hdmipi4m shield definition #55493

boards: shields: add rk055hdmipi4m shield definition #55493

Conversation

danieldegrasse commented Mar 6, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danieldegrasse commented May 12, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danieldegrasse May 15, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danieldegrasse commented Jun 22, 2023

erwango left a comment

Choose a reason for hiding this comment

danieldegrasse commented Mar 6, 2023 •

edited

danieldegrasse May 15, 2023 •

edited