Add support of h3ulcb and salvator xs m3 arm64 boards #57172

xakep-amatop · 2023-04-24T09:18:28Z

Add generic Renesas functions to CPG for getting/setting rates of clocks. Add associated tables of clocks and API for working with these tables.

Add MMIO mapping for PFC, UART and CPG Renesas drivers in order to avoid mappings inside mmu_regions.c file(s).

Added files for supporting ARM64 Renesas r8a77951/r8a77961 SoCs:
* add dtsi for r8a77951/r8a77961 soc;
* files for support PFC;

Add basic support of rcar_salvator_xs_m3 and rcar_h3ulcb_ca57 ARM64 boards.

gmarull · 2023-04-24T12:59:36Z

soc/arm64/renesas_rcar/gen3/soc.h

+ *
+ */
+
+#ifndef _SOC__H_


-1 to soc.h, not needed for ARM64

gmarull · 2023-04-24T12:59:45Z

soc/arm64/renesas_rcar/gen3/soc.c

+#include <zephyr/arch/cpu.h>
+#include <zephyr/device.h>
+#include <zephyr/init.h>
+#include <zephyr/kernel.h>
+#include <soc.h>
+
+/**
+ *
+ * @brief Perform basic hardware initialization
+ *
+ * @return 0
+ */
+
+static int soc_init(void)
+{
+	/* Install default handler that simply resets the CPU
+	 * if configured in the kernel, NOP otherwise
+	 */
+	return 0;
+}
+
+SYS_INIT(soc_init, PRE_KERNEL_1, CONFIG_KERNEL_INIT_PRIORITY_DEFAULT);


this file does nothing

gmarull · 2023-04-24T13:00:08Z

soc/arm64/renesas_rcar/gen3/pinctrl_soc.h

+ *
+ */
+
+#ifndef ZEPHYR_SOC_ARM_RENESAS_RCAR_GEN3_PINCTRL_SOC_H_


nit: add a separate commit introducing pinctrl?

Add associative tables for core and mod clocks. Add possibility to enable/disable any of core clocks which presents in the associative table. Add handler for setting rate to driver and use generic rcar cpg function for getting rate. Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>

Delete IRQ lock/unlock calls from 'rcar_cpg_mstp_clock_endisable', because 'rcar_cpg_mstp_clock_endisable' function is always called under spin lock. Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>

Add MMIO mapping for Renesas CPG driver in order to avoid mappings inside mmu_regions.c file. Remove MMU region for Renesas CPG driver. Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>

Add files for supporting arm64 Renesas r8a77951 SoC. Add config option CPU_CORTEX_A57. Enable build of clock_control_r8a7795_cpg_mssr.c for a new ARM64 SoC R8A77951. Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>

Add Pin Function Controller tables of registers and their bits for ARM64 Renesas R-Car family. With this changes we can use Renesas PFC driver for configuring bias and driving capabilities. Note: some of files copy-pasted from Renesas Arm 32 SoC directory and this commit is a temporary solution, we need to rework it in order to use the same source files for both architectures. Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>

Add basic functionality for supporting h3ulcb board: * add documentation for h3ulcb board; * add pinctrl dtsi for scif driver; * add dts, yaml and configuration files. Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>

Add support of r8a77961 SoC to gen3 series. Create a dtsi file with a common part for both r8a77951 and r8a77961. Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>

Add Pin Function Controller tables of registers and their bits for ARM64 Renesas R-Car family. With this changes we can use Renesas PFC driver for configuring bias and driving capabilities. Add only needed driver strength and bias pins to PFC, e.g. SDx and UART TX/RX pins. Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>

Add support of 'rcar_salvator_xs_m3' board: minimal dts and configuration. Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>

Renesas R-Car ARM64 platforms entry has been added to maintainers list. lorc (Volodymyr Babchuk <volodymyr_babchuk@epam.com>) will be a maintainer of the Renesas R-Car boards based on ARMv8. Signed-off-by: Mykola Kvach <mykola_kvach@epam.com> Acked-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>

xakep-amatop · 2023-06-27T12:41:35Z

rebased onto the latest changes + added Renesas R-Car ARM64 entry to the maintainers list (last commit)

carlocaione

For the arch part

lorc

For adding me as a maintainer

de-nordic

MCUmgr is OK.

stale, addressed

carlescufi · 2023-07-11T09:17:31Z

Compliance failure is the usual pin control typedef.

aaillet · 2023-07-11T09:54:01Z

In fact PR wasn't ready to be merged, I was working on the clock changes review as it is containing errors and kept my "change needed" while doing it.
Sorry I took that much time, I will then address these errors in a new PR !

carlocaione · 2023-07-11T09:56:18Z

In fact PR wasn't ready to be merged

Next time please keep it in draft state until ready to be merged.

aaillet · 2023-07-11T09:59:55Z

In fact PR wasn't ready to be merged

Next time please keep it in draft state until ready to be merged.

I'm not PR author, was I able to do that ?
I wasn't aware, that's why I used "changes needed" to block the PR

aaillet · 2023-07-11T10:04:45Z

I validated that these changes didn't broke R7 (arm32) support of H3. I'm deeply reviewing clock control changes, I'll let you know.

I said that I was working on the clock control review (but not updated my status) as maintainer, but anyway, I'll fix it on another PR !

xakep-amatop · 2023-07-11T10:32:39Z

I validated that these changes didn't broke R7 (arm32) support of H3. I'm deeply reviewing clock control changes, I'll let you know.

I said that I was working on the clock control review (but not updated my status) as maintainer, but anyway, I'll fix it on another PR !

Feel free to write comments about any issues you've found in the CPG driver here. If you'd like, I can address them and open a new pull request.

xakep-amatop force-pushed the zephyr-arm64-add-support-of-h3ulcb-salvator-xs-boards branch 3 times, most recently from 2f31169 to e110128 Compare April 24, 2023 12:39

xakep-amatop changed the title ~~Zephyr arm64 add support of h3ulcb salvator xs boards~~ Zephyr arm64 add support of h3ulcb and salvator xs m3 boards Apr 24, 2023

xakep-amatop changed the title ~~Zephyr arm64 add support of h3ulcb and salvator xs m3 boards~~ Add support of h3ulcb and salvator xs m3 arm64 boards Apr 24, 2023

xakep-amatop force-pushed the zephyr-arm64-add-support-of-h3ulcb-salvator-xs-boards branch from e110128 to cec7719 Compare April 24, 2023 12:50

xakep-amatop marked this pull request as ready for review April 24, 2023 12:51

xakep-amatop requested review from nashif, carlescufi, galak, MaureenHelm, carlocaione, aaillet and gmarull as code owners April 24, 2023 12:51

zephyrbot added area: UART Universal Asynchronous Receiver-Transmitter area: Pinctrl area: ARM64 ARM (64-bit) Architecture area: Fuel Gauge area: Clock Control platform: Renesas R-Car Renesas R-Car labels Apr 24, 2023

zephyrbot requested review from aaronemassey, dcpleung, nordic-krch, npitre, pmarzin, povergoing, SgrrZhf and teburd April 24, 2023 12:52

zephyrbot assigned carlocaione Apr 24, 2023

gmarull previously requested changes Apr 24, 2023

View reviewed changes

xakep-amatop added 10 commits June 27, 2023 11:47

drivers: rcar_cpg: delete irq lock/unlock from mstp_clock_endisable

e2ea8e3

Delete IRQ lock/unlock calls from 'rcar_cpg_mstp_clock_endisable', because 'rcar_cpg_mstp_clock_endisable' function is always called under spin lock. Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>

drivers: rcar_cpg: do MMIO mapping inside driver

9f4cc47

Add MMIO mapping for Renesas CPG driver in order to avoid mappings inside mmu_regions.c file. Remove MMU region for Renesas CPG driver. Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>

soc: arm64: add Renesas Rcar Gen3 SoC support

3f6bc92

Add files for supporting arm64 Renesas r8a77951 SoC. Add config option CPU_CORTEX_A57. Enable build of clock_control_r8a7795_cpg_mssr.c for a new ARM64 SoC R8A77951. Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>

boards: arm64: add Renesas H3ULCB CA57 board support

8d54260

Add basic functionality for supporting h3ulcb board: * add documentation for h3ulcb board; * add pinctrl dtsi for scif driver; * add dts, yaml and configuration files. Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>

soc: arm64: add support of r8a77961

6bf5797

Add support of r8a77961 SoC to gen3 series. Create a dtsi file with a common part for both r8a77951 and r8a77961. Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>

boards: arm64: add support of Salvator XS M3 board

aa72541

Add support of 'rcar_salvator_xs_m3' board: minimal dts and configuration. Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>

xakep-amatop dismissed stale reviews from nordicjm, de-nordic, and carlocaione via 01f74f9 June 27, 2023 12:36

xakep-amatop force-pushed the zephyr-arm64-add-support-of-h3ulcb-salvator-xs-boards branch from 7b09a0c to 01f74f9 Compare June 27, 2023 12:36

zephyrbot added the area: Process label Jun 27, 2023

carlocaione approved these changes Jun 27, 2023

View reviewed changes

lorc approved these changes Jun 27, 2023

View reviewed changes

de-nordic approved these changes Jul 10, 2023

View reviewed changes

carlescufi merged commit 832e1e2 into zephyrproject-rtos:main Jul 11, 2023
26 of 27 checks passed

aaillet mentioned this pull request Jul 11, 2023

Add support of rcar spider board #60252

Closed

aaillet mentioned this pull request Jul 21, 2023

boards: arm: Add Renesas Spider board #56043

Merged

lorc mentioned this pull request Aug 16, 2023

Nominate @lorc as a Contributor #61574

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support of h3ulcb and salvator xs m3 arm64 boards #57172

Add support of h3ulcb and salvator xs m3 arm64 boards #57172

xakep-amatop commented Apr 24, 2023 •

edited

gmarull Apr 24, 2023

xakep-amatop May 2, 2023

gmarull Apr 24, 2023

xakep-amatop May 2, 2023

gmarull Apr 24, 2023

xakep-amatop May 2, 2023

xakep-amatop commented Jun 27, 2023

carlocaione left a comment

lorc left a comment

de-nordic left a comment

carlescufi commented Jul 11, 2023

aaillet commented Jul 11, 2023

carlocaione commented Jul 11, 2023

aaillet commented Jul 11, 2023

aaillet commented Jul 11, 2023

xakep-amatop commented Jul 11, 2023

Add support of h3ulcb and salvator xs m3 arm64 boards #57172

Add support of h3ulcb and salvator xs m3 arm64 boards #57172

Conversation

xakep-amatop commented Apr 24, 2023 • edited

gmarull Apr 24, 2023

Choose a reason for hiding this comment

xakep-amatop May 2, 2023

Choose a reason for hiding this comment

gmarull Apr 24, 2023

Choose a reason for hiding this comment

xakep-amatop May 2, 2023

Choose a reason for hiding this comment

gmarull Apr 24, 2023

Choose a reason for hiding this comment

xakep-amatop May 2, 2023

Choose a reason for hiding this comment

xakep-amatop commented Jun 27, 2023

carlocaione left a comment

Choose a reason for hiding this comment

lorc left a comment

Choose a reason for hiding this comment

de-nordic left a comment

Choose a reason for hiding this comment

carlescufi commented Jul 11, 2023

aaillet commented Jul 11, 2023

carlocaione commented Jul 11, 2023

aaillet commented Jul 11, 2023

aaillet commented Jul 11, 2023

xakep-amatop commented Jul 11, 2023

xakep-amatop commented Apr 24, 2023 •

edited