Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of rcar spider board #60252

Closed
wants to merge 5 commits into from
Closed

Add support of rcar spider board #60252

wants to merge 5 commits into from

Conversation

xakep-amatop
Copy link
Contributor

@xakep-amatop xakep-amatop commented Jul 11, 2023 •
edited

  • add support of r8a779f SoC and R-Car Spider board;
  • add voltage control to R-Car pinctrl driver (R-Car Gen3 & Gen4 boards based on ARMv8-A).

Note 1: currently, the board can be used only as a Xen Initial Domain, i.e. Dom0, because there isn't support of UART driver. So, it can be built only with xen_dom0 shield.

Note 2: xen_dom0 shield code is still under review too. You can find pull-request here: #59145.

@xakep-amatop
soc: arm64: add support of r8a779f
8fd1e35 
Add support of r8a779f SoC and appropriate dts file
with minimal set of nodes.

Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>
@xakep-amatop
drivers: clock_control: add support of r8a779f cpg driver
9180790 
Add support of r8a779f cpg driver

Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>
@xakep-amatop
soc: arm64: add support of pinctrl for r8a779f
ea55fb6 
Add support of pinctrl for r8a779f.

Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>
@xakep-amatop xakep-amatop force-pushed the add-support-of-rcar-spider-board branch from 1b8b576 to 7bafd74 Compare July 11, 2023 14:01
@xakep-amatop
boards: arm64: add support of Renesas Spider board
d83b7a2 
Add support of 'rcar_spider' board: minimal dts
and configuration.

Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>
@xakep-amatop
drivers: pinctrl: pfc_rcar: add support of voltage control to pfc driver
289e15b 
Add support of voltage control to Renesas PFC driver. Voltage register
mappings have been added to r8a7795, r8a7796 and r8a779f SoCs.

Allow 'power-source' property for 'renesas,rcar-pfc' node. This property
will be used for configuring IO voltage on appropriate pin. For now it
is possible to have only two voltages: 1.8 and 3.3.

Note: it is possible to change voltage only for SD/MMC pins on r8a7795
      and r8a7796 SoCs, r8a779f supports more pins for configuring
      voltage, but only SD/MMC pins have been added to the array.

Signed-off-by: Mykola Kvach <mykola_kvach@epam.com>
@xakep-amatop xakep-amatop force-pushed the add-support-of-rcar-spider-board branch from 7bafd74 to 289e15b Compare July 11, 2023 14:33
@xakep-amatop xakep-amatop marked this pull request as ready for review July 11, 2023 14:42
@zephyrbot zephyrbot added platform: Renesas R-Car ARM64 Renesas Electronics Corporation, R-Car ARM64 platform: Renesas R-Car Renesas R-Car area: Fuel Gauge area: ARM64 ARM (64-bit) Architecture area: Clock Control area: Pinctrl area: Devicetree Binding PR modifies or adds a Device Tree binding labels Jul 11, 2023
@aaillet
Copy link
Member

aaillet commented Jul 11, 2023

Some work, especially for adapting drivers to Gen4 SoCs is already in a Pull Request here : #56043
As your rework of cpg driver as been merged here #57172, your work for r8a779f0 cpg driver is welcome but for other drivers, we should maybe not propose two PR doing it at the same time.
What do you think about collaborating merging some of our work ?

@xakep-amatop
Copy link
Contributor Author

What do you think about collaborating merging some of our work ?

Sure! What should I do on my end?

@aaillet
Copy link
Member

aaillet commented Jul 12, 2023

What do you think about collaborating merging some of our work ?

Sure! What should I do on my end?

Are you part of the Zephyr discord server ? Or can you be ?
It would be nice to use a direct messaging app to discuss our plan to merge our work if it's ok for you !
Link to the server can be found here : https://docs.zephyrproject.org/latest/develop/getting_started/index.html#asking-for-help

@xakep-amatop
Copy link
Contributor Author

Discussed changes with @aaillet. I'll convert this pull request into a draft until #56043 is merged. Some of my changes related to CPG driver will be moved to the #56043.

@xakep-amatop xakep-amatop marked this pull request as draft July 12, 2023 13:07
@aaillet aaillet mentioned this pull request Jul 17, 2023
Merged
@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Sep 11, 2023
@gmarull gmarull removed their request for review September 19, 2023 07:11
@github-actions github-actions bot removed the Stale label Sep 20, 2023
@github-actions GitHub Actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Nov 19, 2023
@aaillet aaillet removed the Stale label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nashif nashif Awaiting requested review from nashif

@carlescufi carlescufi Awaiting requested review from carlescufi

@galak galak Awaiting requested review from galak

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@carlocaione carlocaione Awaiting requested review from carlocaione

@aaillet aaillet Awaiting requested review from aaillet aaillet is a code owner

@aaronemassey aaronemassey Awaiting requested review from aaronemassey

@lorc lorc Awaiting requested review from lorc lorc is a code owner

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@npitre npitre Awaiting requested review from npitre

@pmarzin pmarzin Awaiting requested review from pmarzin

@povergoing povergoing Awaiting requested review from povergoing

@SgrrZhf SgrrZhf Awaiting requested review from SgrrZhf

@teburd teburd Awaiting requested review from teburd

Assignees
No one assigned
Labels
area: ARM64 ARM (64-bit) Architecture area: Clock Control area: Devicetree Binding PR modifies or adds a Device Tree binding area: Fuel Gauge area: Pinctrl platform: Renesas R-Car ARM64 Renesas Electronics Corporation, R-Car ARM64 platform: Renesas R-Car Renesas R-Car
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xakep-amatop @aaillet @zephyrbot