Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Microchip CAN-FD MCP251xFD drivers #59968

Merged
merged 4 commits into from Oct 1, 2023
Merged

Add Microchip CAN-FD MCP251xFD drivers #59968

merged 4 commits into from Oct 1, 2023

Conversation

talih0
Copy link
Contributor

@talih0 talih0 commented Jul 3, 2023

Continues PR #31270

@zephyrbot zephyrbot added area: Shields Shields (add-on boards) platform: Infineon Infineon Technologies AG platform: Microchip MEC Microchip MEC Platform area: CAN area: Devicetree Binding PR modifies or adds a Device Tree binding labels Jul 3, 2023
@talih0 talih0 force-pushed the mcp2518fd branch 2 times, most recently from 7c9420a to b24a027 Compare July 3, 2023 19:25
@talih0 talih0 requested review from legoabram and removed request for VenkatKotakonda July 3, 2023 19:26
henrikbrixandersen
henrikbrixandersen requested changes Jul 4, 2023
View reviewed changes
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split this PR into at least three separate PRs:

  • One for the xmc47_relax_kit board changes.
  • One for the adding the arduino_uno_click shield.
  • Keep this one for adding the MCP25xxFD driver + the mcp2518fd shield.

@talih0
Copy link
Contributor Author

talih0 commented Jul 4, 2023

Please split this PR into at least three separate PRs:

* One for the xmc47_relax_kit board changes.

* One for the adding the arduino_uno_click shield.

* Keep this one for adding the MCP25xxFD driver + the mcp2518fd shield.

sure, will do. I did it this way because sample/drivers/can/counter needs all commits to run on xmc47_relax_kit. I'll add the sample later after the separate PRs are merged.

@talih0 talih0 mentioned this pull request Jul 4, 2023
Merged
@talih0
Copy link
Contributor Author

talih0 commented Jul 4, 2023 •
edited

On the mcp2518fd click shield, I changed the example to lpcxpresso55s28 so that the PR is independent of my xmc47_relax_kit/arduino uno click shield commits.
The compilation for lpcxpresso55s28 works, but I don't have the board to test.

@talih0
Copy link
Contributor Author

talih0 commented Sep 21, 2023

@henrikbrixandersen, I pushed the rebased version.

jfischer-no
jfischer-no previously approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@jfischer-no jfischer-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shield LGTM

@legoabram @talih0
drivers: can: Implement MCP25xxFD driver
533795f 
Implementation for Microchip MCP2517FD/MCP2518FD SPI based CAN-FD
controller.

Signed-off-by: Abram Early <abram.early@gmail.com>
henrikbrixandersen
henrikbrixandersen requested changes Sep 29, 2023
View reviewed changes
tests/drivers/build_all/can/testcase.yaml Outdated Show resolved Hide resolved
drivers/can/can_mcp251xfd.c Show resolved Hide resolved
drivers/can/can_mcp251xfd.c Outdated Show resolved Hide resolved
drivers/can/can_mcp251xfd.c Outdated Show resolved Hide resolved
drivers/can/can_mcp251xfd.c Show resolved Hide resolved
drivers/can/can_mcp251xfd.c Outdated Show resolved Hide resolved
drivers/can/can_mcp251xfd.c Outdated Show resolved Hide resolved
drivers/can/can_mcp251xfd.c Outdated Show resolved Hide resolved
drivers/can/can_mcp251xfd.c Outdated Show resolved Hide resolved
drivers/can/can_mcp251xfd.c Outdated Show resolved Hide resolved
@talih0
drivers: can: mcp251xfd: Add driver
37dc289 
This continue PR zephyrproject-rtos#31270. The updated changes are:
- Updated to work with latest zephyr
- Inplace reads/writes of registers
- Batch read of RX messages when multiple messages can be read
- FIFO abstraction of RX/TEF queues
- Handle ivmif errors
- Use READ_CRC for register reads
- Use bitmasks instead of bitfield members
- Rename mcp25xxfd to mcp251xfd
- General cleanups

Signed-off-by: Andriy Gelman <andriy.gelman@gmail.com>
@talih0
shields: Add CAN-FD MikroElektronika mcp2518fd click shield
ef3c962 
Adds MikroElektronica click shield for the Microchip
MCP2518FD CAN-FD controller.

Signed-off-by: Andriy Gelman <andriy.gelman@gmail.com>
@talih0
tests: drivers: build_all: can: Add mcp251xfd test case
e903aba 
Adds build test case for mcp25xxfd with arduino_uno_click and
mikroe_mcp2518fd_click shield.

Signed-off-by: Andriy Gelman <andriy.gelman@gmail.com>
@henrikbrixandersen henrikbrixandersen added this to the v3.5.0 milestone Sep 29, 2023
@henrikbrixandersen
Copy link
Member

@str4t0m, @erwango, @jfischer-no Please revisit.

@str4t0m str4t0m dismissed their stale review September 30, 2023 18:43

I've not reviewed all the latest changes, but my earlyier change requests have been addressed.

@kartben
Copy link
Collaborator

kartben commented Sep 30, 2023

@jhedberg @fabiobaltieri in case there's still time to get it into RC1

@jhedberg jhedberg merged commit 1211d77 into zephyrproject-rtos:main Oct 1, 2023
18 checks passed
@talih0
Copy link
Contributor Author

talih0 commented Oct 1, 2023

thank you everyone for your reviews and getting this merged into 3.5

@henrikbrixandersen
Copy link
Member

thank you everyone for your reviews and getting this merged into 3.5

Thank you for taking up this work and thank you to @legoabram for the initial PR. This driver is an important addition to the existing range of Zephyr CAN drivers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhedberg jhedberg jhedberg approved these changes

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@jfischer-no jfischer-no jfischer-no approved these changes

@nashif nashif Awaiting requested review from nashif

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@galak galak Awaiting requested review from galak

@avisconti avisconti Awaiting requested review from avisconti

@ifyall ifyall Awaiting requested review from ifyall

@jvasanth1 jvasanth1 Awaiting requested review from jvasanth1

@karstenkoenig karstenkoenig Awaiting requested review from karstenkoenig

@martinjaeger martinjaeger Awaiting requested review from martinjaeger

@npal-cy npal-cy Awaiting requested review from npal-cy

@legoabram legoabram Awaiting requested review from legoabram

@erwango erwango Awaiting requested review from erwango

@str4t0m str4t0m Awaiting requested review from str4t0m

@alexanderwachter alexanderwachter Awaiting requested review from alexanderwachter alexanderwachter is a code owner

@fabiobaltieri fabiobaltieri Awaiting requested review from fabiobaltieri

Assignees

@henrikbrixandersen henrikbrixandersen

Labels
area: CAN area: Devicetree Binding PR modifies or adds a Device Tree binding area: Shields Shields (add-on boards) platform: Microchip MEC Microchip MEC Platform
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

None yet