Add support for Arduino UNO R4 #60760

soburi · 2023-07-25T07:22:05Z

Adds support for Arduino UNO R4.

I have verified that hello_world, blinky, and button sample work with this PR.

We can flash and debug with the cmsis-dap adapter and pyOCD.
But not supporting flash program with dfu-util, because Arduino IDE use not standard version of dfu-util.

To avoid complicating initial code for supporting the SoC,
I have implemented only the bare minimum for now.

~~We can't use FSP that the BSP Renesas provides is not an OSS license (It doesn't allow execution outside of Renesas SoCs).~~
~~I write this PR entirely from scratch, so it is not dependent on FSP.~~
~~But it is good to use FSP for reliability reasons if we can use it.~~

~~This PR is still remain some TODOs.~~
~~Because it still needs to complete implementing some functions (clock_control, pinctrl, etc.), mark them as TODO,~~
~~depending on it.~~

~~This PR changes R-Car UART driver to support RA UART.~~
~~But I don't have R-Car board, so I can't test it.~~

~~If Renesas plans to support Zephyr officially, I would prefer to follow that policy. (But that doesn't mean we can't proceed without it.)~~

fabiobaltieri · 2023-07-27T15:44:53Z

If Renesas officially supports Zephyr, I would prefer to follow that policy. However if not so, proceeding on a community basis is necessary. Has anyone heard the intentions of Renesas?

There's a HAL already for SmartBond devices (https://github.com/zephyrproject-rtos/hal_renesas) and code for both that and R-Car.

@andrzej-kaczmarek @blauret @aaillet @lorc any idea if there's interest to have official support for RA family?

lorc · 2023-07-27T21:00:41Z

My team is mostly interested in CortexA cores and virtualization, so I'm afraid no one from my side can help with this.

blauret · 2023-07-28T06:04:34Z

It's great initiative. Just a few comments:

Debugging is supported with JLink (See R7FA4M1AB) . You don't need the Renesas debug server. JLink is widely accepted debug option in the Zephyr environment.
For the licensing side of the FSP package, I'm not sure how it works but Platformio does provide and RA package. If think they figured a way to support that environment, it should be possible to comply with Zephyr community requirements.

My team is focused on the Smartbond devices. I'll try to reach out in the organization to see if someone can help. That said, it's en of July and it's summer holidays it could take some time.

soburi · 2023-07-30T01:00:36Z

@fabiobaltieri @lorc @blauret

Thank you for responses.

Debugging is supported with JLink (See R7FA4M1AB) . You don't need the Renesas debug server. JLink is widely accepted debug option in the Zephyr environment.

I misunderstood the need for Renesas-specific software for debugging.
I verify it can debug with JLink and pyOCD.
I made pyocd the default because cmsis-dap adapters are easy to obtain.

For the licensing side of the FSP package, I'm not sure how it works but Platformio does provide and RA package. If think they figured a way to support that environment, it should be possible to comply with Zephyr community requirements.

At a glance, RA package contains no FSP sources. FSP sources are in the separated repository framework-renesas-fsp.
So, It still needs consideration...

My team is mostly interested in CortexA cores and virtualization, so I'm afraid no one from my side can help with this.

My team is focused on the Smartbond devices. I'll try to reach out in the organization to see if someone can help.

Thanks a lot.
I know there are some things difficult in large organization.
Could you tell me any news (or rumor?) if you get in future.

That said, it's en of July and it's summer holidays it could take some time.

Have a nice holidays!

aaillet · 2023-07-31T06:47:51Z

Hi,

I'm afraid that as people from other teams, I'm mainly focusing on my part, Cortex-R support for R-Car SoCs.

From my point of view, Smartbond code and HAL will not fit RA series as Smartbond is coming from a brand that Renesas bought. As this series was already existing before it's brand acquirement, I think it's not using Renesas IPs.

On the other hand, it may be possible to reuse R-CAR code if same IPs are used.

Concerning interest from Renesas to officially support Zephyr on RA/RZ this series, I'll ask my internal contact if plans are existing !

soburi · 2023-08-02T13:01:31Z

@aaillet

Hi,

I'm afraid that as people from other teams, I'm mainly focusing on my part, Cortex-R support for R-Car SoCs.

Thank you for response.

From my point of view, Smartbond code and HAL will not fit RA series as Smartbond is coming from a brand that Renesas bought. As this series was already existing before it's brand acquirement, I think it's not using Renesas IPs.

I got it. The smartbond HAL provide with Apache2 license.
There was no problem to integrate to zephyr. It is different with RA.

On the other hand, it may be possible to reuse R-CAR code if same IPs are used.

From this viewpoint, using BSP may not be suitable if making a standard driver between series.
At a glance, UART and CAN drivers seem to be able to be commonized between R-Car and RA.
Some register configurations are different, but these share the same basis.
(SCI has been used longly in Renesas SoC since the 8-bit MCU era, so there are many variations. I don't know whether it is good or not that one driver should support all of these, but it seems better to try to commonize them.)
I added support for the RA series UART with the R-Car UART driver.

Concerning interest from Renesas to officially support Zephyr on RA/RZ this series, I'll ask my internal contact if plans are existing !

Thanks a lot!
I am confident that the RA series and the UNO R4 are valuable for supporting it!

gmarull · 2023-10-31T11:51:03Z

dts/bindings/pinctrl/renesas,ra-pinctrl.yaml

+        property-allowlist:
+          - bias-disable
+          - bias-pull-up
+          - drive-open-drain
+          - input-enable
+          - drive-strength


where are these handled? I can't see them being referenced in pinctrl_soc.h

Not yet implemented these, but the reference manual says, these functions exist.
I am adding these for now as I will implement them in the near future.
Is it better not to enter it at this time?

If they're not used, they shouldn't be allowed yet, this will create confusion to the users.

Ah, I got it.
I removed it.

To avoid complicating the initial code for supporting the SoC, I have implemented only the bare minimum for now. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>

gmarull · 2023-10-31T12:35:27Z

dts/bindings/pinctrl/renesas,ra-pinctrl.yaml

+    include:
+      - name: pincfg-node.yaml


this should be removed entirely, none of the props are used right?

I had a little misunderstanding. I deleted it additionally.
Thank you for pointing it out.

gmarull · 2023-10-31T12:57:33Z

drivers/interrupt_controller/intc_ra_icu.c

+static int ra_icu_init(const struct device *dev)
+{
+	ARG_UNUSED(dev);
+
+	return 0;
+}
+
+DEVICE_DT_INST_DEFINE(0, ra_icu_init, NULL, NULL, NULL, PRE_KERNEL_1, CONFIG_INTC_INIT_PRIORITY,


just pass NULL to the init function, it;s now optional

I fixed as so.

gmarull · 2023-10-31T12:58:24Z

dts/arm/renesas/ra/ra-cm4-common.dtsi

+			reg = <0x40040020 0x20>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			port-no = <1>;


why is this property needed? this is not hw description?

Yes, it is an index of gpio.
The index can be calculated from the address.
I replaced it with the calculated value.

fancy, you sure the new one is a good idea? it relies on the port memory space being contiguous (question for both of you @soburi @gmarull)

In the RA series, all GPIO ports use continuous addresses. Even if there is a dropout in the middle, the port number will not change, so calculation is possible.

CM4-based SoC uses 0x40040000 to 0x40040160 for ioport0 .. ioportb.
In the case of CM33-based SoC, it also uses 0x40080000 to 0x40080160.

In past situations, we've always restricted DT to the hardware description itself (port-no is needed here because of how software works, not because it describes hw uniquely).

gmarull · 2023-10-31T13:00:12Z

drivers/gpio/gpio_ra.c

+static int gpio_ra_init(const struct device *dev)
+{
+	return 0;
+}


To avoid complicating the initial code for supporting the SoC, I have implemented only the bare minimum for now. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>

Add initial support for Renesas RA GPIO. To avoid complicating the initial code for supporting the SoC, I have implemented only the bare minimum for now. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>

Adding initial support for Renesas RA UART. To avoid complicating initial code for supporting the SoC, I have implemented only the bare minimum for now. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>

Add support for the Arduino UNO R4 Minima. This board is the newest version of Arduino that uses Renesas RA4M1 SoC. This commit provides only limited support to simplify the initial support patch. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>

Renesas RA always uses interrupt handlers dynamically. But this test requires static vector tables. So, it needs to exclude platforms that use Renesas RA. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>

eGit · 2024-01-25T07:49:53Z

What's keeping Zephyr from supporting Arduino Uno R3? Not enough RAM?

soburi · 2024-01-25T13:15:34Z

@eGit

What's keeping Zephyr from supporting Arduino Uno R3? Not enough RAM?

ZephyrRTOS intends 32bit/64bit MPUs. I think it may difficult to port 16bit/8bit.

soburi force-pushed the arduino_uno_r4 branch from 2b89a41 to d6bbdb4 Compare July 25, 2023 09:14

soburi changed the title ~~Add supporting Arduino UNO R4 (and FPB_RA6E1)~~ Add support for Arduino UNO R4 (and FPB_RA6E1) Jul 25, 2023

soburi force-pushed the arduino_uno_r4 branch 3 times, most recently from 27041f5 to 00560d7 Compare July 29, 2023 13:31

soburi force-pushed the arduino_uno_r4 branch from 00560d7 to 0c2cf44 Compare July 30, 2023 01:20

soburi force-pushed the arduino_uno_r4 branch from 0c2cf44 to 49456c7 Compare August 1, 2023 00:24

soburi changed the title ~~Add support for Arduino UNO R4 (and FPB_RA6E1)~~ Add support for Arduino UNO R4 Aug 1, 2023

soburi force-pushed the arduino_uno_r4 branch 7 times, most recently from 3cba69b to 1971b88 Compare August 2, 2023 11:35

soburi marked this pull request as ready for review August 2, 2023 13:37

soburi requested review from nashif, galak, aaillet, pmarzin, gmarull, mnkp, MaureenHelm and ioannisg as code owners August 2, 2023 13:37

gmarull reviewed Oct 31, 2023

View reviewed changes

drivers: pinctrl: Add pinctrl driver for Renesas RA series

571c8a7

To avoid complicating the initial code for supporting the SoC, I have implemented only the bare minimum for now. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>

soburi dismissed fabiobaltieri’s stale review via 389a7dd October 31, 2023 12:25

soburi force-pushed the arduino_uno_r4 branch from 11b4b57 to 389a7dd Compare October 31, 2023 12:25

gmarull reviewed Oct 31, 2023

View reviewed changes

soburi force-pushed the arduino_uno_r4 branch from 389a7dd to 891ac1d Compare October 31, 2023 12:42

gmarull reviewed Oct 31, 2023

View reviewed changes

drivers: interrupt_controller: Add icu driver for Renesas RA series

555e2cf

To avoid complicating the initial code for supporting the SoC, I have implemented only the bare minimum for now. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>

soburi force-pushed the arduino_uno_r4 branch from 891ac1d to 722751a Compare October 31, 2023 13:18

soburi added 4 commits October 31, 2023 22:41

drivers: gpio: Add GPIO driver for Renesas RA series

e401632

Add initial support for Renesas RA GPIO. To avoid complicating the initial code for supporting the SoC, I have implemented only the bare minimum for now. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>

drivers: serial: Add UART driver for Renesas RA series

72aa85b

Adding initial support for Renesas RA UART. To avoid complicating initial code for supporting the SoC, I have implemented only the bare minimum for now. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>

tests: arch: arm: arm_irq_vector_table: exclude arduino_uno_r4_minima

9c4de38

Renesas RA always uses interrupt handlers dynamically. But this test requires static vector tables. So, it needs to exclude platforms that use Renesas RA. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@fujitsu.com>

soburi force-pushed the arduino_uno_r4 branch from 722751a to 9c4de38 Compare October 31, 2023 13:43

soburi requested review from gmarull and fabiobaltieri October 31, 2023 14:26

gmarull approved these changes Oct 31, 2023

View reviewed changes

fabiobaltieri approved these changes Oct 31, 2023

View reviewed changes

fabiobaltieri assigned soburi and unassigned nordic-krch Nov 1, 2023

fabiobaltieri merged commit a17d495 into zephyrproject-rtos:main Nov 1, 2023
19 checks passed

soburi deleted the arduino_uno_r4 branch November 1, 2023 10:57

golowanow mentioned this pull request Nov 3, 2023

soc: arm: Fix linker.ld depreciation warning for arduino_uno_r4_minima #64789

Merged

soburi mentioned this pull request Nov 26, 2023

Fixed bugs that could not be fixed in the first commit of arduino_uno_r4 #65774

Merged

aaillet mentioned this pull request Jan 11, 2024

MAINTAINERS+dts: Create & Update Renesas ranges area #67487

Merged

soburi mentioned this pull request Jan 16, 2024

Nominate @soburi as contributor #67642

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Arduino UNO R4 #60760

Add support for Arduino UNO R4 #60760

soburi commented Jul 25, 2023 •

edited

fabiobaltieri commented Jul 27, 2023

lorc commented Jul 27, 2023

blauret commented Jul 28, 2023

soburi commented Jul 30, 2023

aaillet commented Jul 31, 2023

soburi commented Aug 2, 2023

gmarull Oct 31, 2023

soburi Oct 31, 2023

gmarull Oct 31, 2023

soburi Oct 31, 2023

gmarull Oct 31, 2023

soburi Oct 31, 2023

gmarull Oct 31, 2023

soburi Oct 31, 2023

gmarull Oct 31, 2023

soburi Oct 31, 2023

fabiobaltieri Oct 31, 2023

soburi Oct 31, 2023

gmarull Oct 31, 2023

gmarull Oct 31, 2023

soburi Oct 31, 2023

eGit commented Jan 25, 2024

soburi commented Jan 25, 2024

Add support for Arduino UNO R4 #60760

Add support for Arduino UNO R4 #60760

Conversation

soburi commented Jul 25, 2023 • edited

fabiobaltieri commented Jul 27, 2023

lorc commented Jul 27, 2023

blauret commented Jul 28, 2023

soburi commented Jul 30, 2023

aaillet commented Jul 31, 2023

soburi commented Aug 2, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eGit commented Jan 25, 2024

soburi commented Jan 25, 2024

soburi commented Jul 25, 2023 •

edited