Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soc: arm: Fix linker.ld depreciation warning for arduino_uno_r4_minima #64789

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

golowanow
Copy link
Member

@golowanow golowanow commented Nov 3, 2023

Fix cmake depreciation warning on pre-defined linker.id (soc/arm/renesas_ra/ra4m1/linker.ld) used for arduino_uno_r4_minima.

Fix build issue with linker.ld depreciated for arduino_uno_r4_minima platform and observed on
samples/synchronization/sample.kernel.synchronization after #64544.

see CI build failure -
https://github.com/zephyrproject-rtos/zephyr/actions/runs/6746158923/job/18339718127?pr=64783

@golowanow golowanow added the bug The issue is a bug, or the PR is fixing a bug label Nov 3, 2023
@golowanow golowanow changed the title soc: arm: Fix build issue for arduino_uno_r4_minima soc: arm: Fix linker.ld build issue for arduino_uno_r4_minima Nov 3, 2023
@golowanow golowanow added Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. labels Nov 3, 2023
@golowanow
Copy link
Member Author

golowanow commented Nov 3, 2023

@soburi, FYI w.r.t. #60760

@nashif
Copy link
Member

nashif commented Nov 3, 2023

this is already fixed #64781

@nashif nashif closed this Nov 3, 2023
@nashif nashif reopened this Nov 3, 2023
@golowanow golowanow removed the Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. label Nov 3, 2023
@golowanow
Copy link
Member Author

this is already fixed #64781

right, I see it is fixed for cmake path error, and this fix is now just to resolve cmake depreciation warning on pre-defined linker.ld for this particular board.

@golowanow golowanow changed the title soc: arm: Fix linker.ld build issue for arduino_uno_r4_minima soc: arm: Fix linker.ld depreciation warning for arduino_uno_r4_minima Nov 3, 2023
@golowanow golowanow removed the bug The issue is a bug, or the PR is fixing a bug label Nov 3, 2023
@soburi
Copy link
Member

soburi commented Nov 3, 2023

@golowanow

Thank you for notifying me.
My commit and #64544 just missed each other.
This fix is no problem. But I have added a comment for a minor issue.

Fix cmake depreciation warning on pre-defined linker.id
(soc/arm/renesas_ra/ra4m1/linker.ld) used for arduino_uno_r4_minima.

Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
@carlescufi carlescufi merged commit 82ec639 into zephyrproject-rtos:main Nov 7, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Build System Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants