Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: x86: Add support for Intel Alder Lake boards #61072

Merged
merged 5 commits into from Aug 9, 2023
Merged

boards: x86: Add support for Intel Alder Lake boards #61072

merged 5 commits into from Aug 9, 2023

Conversation

jhedberg
Copy link
Member

@jhedberg jhedberg commented Aug 2, 2023

Add basic support for Intel Alder Lake CRB and RVP boards

@jhedberg jhedberg requested a review from finikorg August 2, 2023 12:49
@jhedberg jhedberg marked this pull request as ready for review August 3, 2023 07:28
@zephyrbot zephyrbot added area: Watchdog Watchdog platform: X86 x86 and x86-64 area: Devicetree Binding PR modifies or adds a Device Tree binding labels Aug 3, 2023
dcpleung
dcpleung previously approved these changes Aug 3, 2023
View reviewed changes
@nashif
Copy link
Member

nashif commented Aug 3, 2023

Can we please move away from 3 charachter acronyms to something a bit more verbose? intel_adl or even intel_alderlake. This is starting get very cryptic IMO.

@jhedberg
Copy link
Member Author

jhedberg commented Aug 4, 2023

Can we please move away from 3 charachter acronyms to something a bit more verbose? intel_adl or even intel_alderlake. This is starting get very cryptic IMO.

I'm fine with that. I think I'd prefer just adding the intel prefix and the short-hand platform version (i.e. intel_adl). The full name is still visible in documentation, etc. Would be good to try to convert all existing platforms within a fairly short time-window, however, so that we don't end up with some intel_ prefixes and some boards without.

@najumon1980 FYI.

finikorg
finikorg previously approved these changes Aug 5, 2023
View reviewed changes
Copy link
Collaborator

@finikorg finikorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will reuse common parts of the doc when PR #60440 is merged.

@nashif
Copy link
Member

nashif commented Aug 5, 2023

I'm fine with that. I think I'd prefer just adding the intel prefix and the short-hand platform version (i.e. intel_adl).

yes, this is fine.

@finikorg @jhedberg
soc: alder_lake: Add Adler Lake SoC
b9c49ee 
Add Adler Lake SoC. The SoC is derived from Elkhart Lake SoC.

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
@jhedberg jhedberg dismissed stale reviews from finikorg and dcpleung via ba0832b August 7, 2023 08:26
@jhedberg
Copy link
Member Author

jhedberg commented Aug 7, 2023

The board names have now been updated to have an intel_ prefix

@jhedberg
Copy link
Member Author

jhedberg commented Aug 8, 2023

@nashif @dcpleung could you please take another look? Thanks.

dcpleung
dcpleung previously approved these changes Aug 8, 2023
View reviewed changes
@martinjaeger martinjaeger removed their request for review August 9, 2023 05:14
finikorg and others added 4 commits August 9, 2023 10:44
@finikorg @jhedberg
boards: Add Alder Lake board definition
4d5b339 
Add initial Alder Lake board definition. Initially copied from ELkhart
Lake which is predecessor of the board.

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
@finikorg @jhedberg
boards: Add watchdog alias
498fca8 
Add watchdog alias for tco_wdt. Note that it needs to be enabled.

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
@finikorg @jhedberg
boards: intel_adl: Disable UARTs by default and enabled when needed
f58b5ff 
Disabled uart0 and uart1 by default in alder_lake.dtsi and enable only
for intel_adl_crb board.

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
@jhedberg
samples: watchdog: Add overlay for Intel Alder Lake boards
a2e987d 
Add watchdog overlays and necessary metadata to support Intel Alder Lake
boards.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
@fabiobaltieri fabiobaltieri merged commit a88808f into zephyrproject-rtos:main Aug 9, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbursztyka tbursztyka tbursztyka approved these changes

@najumon1980 najumon1980 najumon1980 approved these changes

@finikorg finikorg finikorg left review comments

@dcpleung dcpleung dcpleung left review comments

@nashif nashif Awaiting requested review from nashif

@galak galak Awaiting requested review from galak

@katsuster katsuster Awaiting requested review from katsuster

@laurenmurphyx64 laurenmurphyx64 Awaiting requested review from laurenmurphyx64

@martinjaeger martinjaeger Awaiting requested review from martinjaeger

Assignees

@jhedberg jhedberg

Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: Watchdog Watchdog platform: X86 x86 and x86-64
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jhedberg @nashif @tbursztyka @finikorg @dcpleung @najumon1980 @fabiobaltieri @zephyrbot