Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport v2.7-branch] drivers: flash: spi_nor: select largest valid erase operation #61151

Merged
merged 1 commit into from
Nov 17, 2023
Merged

[Backport v2.7-branch] drivers: flash: spi_nor: select largest valid erase operation #61151

merged 1 commit into from
Nov 17, 2023
+1 −1

Conversation

zephyrbot
Copy link
Collaborator

@zephyrbot zephyrbot commented Aug 4, 2023 •
edited by henrikbrixandersen

Backport ea2dd9f from #60943.

Fixes: #60904

@Crzyrndm @github-actions
drivers: flash: spi_nor: select largest valid erase operation
33154e7 
The spi_nor erase op selection was based on the alignment of the end of
the region to be erased. This prevented larger erase operations being
selected in many cases

Closes #60904

Signed-off-by: Joshua Crawford <joshua.crawford@levno.com>
(cherry picked from commit ea2dd9f)
@zephyrbot zephyrbot requested a review from nashif as a code owner August 4, 2023 08:47
@zephyrbot zephyrbot added the Backport Backport PR and backport failure issues label Aug 4, 2023
@henrikbrixandersen
Copy link
Member

@nvlsianpu Please review.

@Laczen
Copy link
Collaborator

Laczen commented Oct 26, 2023

@de-nordic, could you please add your review.

@de-nordic
Copy link
Collaborator

Seems that compliance does not like how the issue is referenced.

@cfriedt cfriedt merged commit e6f70e9 into v2.7-branch Nov 17, 2023
21 of 22 checks passed
@nashif nashif deleted the backport-60943-to-v2.7-branch branch February 13, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Laczen Laczen Laczen approved these changes

@dkalowsk dkalowsk dkalowsk approved these changes

@de-nordic de-nordic de-nordic approved these changes

@nashif nashif Awaiting requested review from nashif nashif is a code owner

@nvlsianpu nvlsianpu Awaiting requested review from nvlsianpu nvlsianpu is a code owner

@jgl-meta jgl-meta Awaiting requested review from jgl-meta

Assignees

@nvlsianpu nvlsianpu

Labels
Backport Backport PR and backport failure issues
Projects
Backports
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@zephyrbot @henrikbrixandersen @Laczen @de-nordic @dkalowsk @cfriedt @nvlsianpu @Crzyrndm