Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: hwinfo: implemented hardware info support for Smartbond #64125

Merged
merged 1 commit into from Dec 27, 2023

Conversation

kasjer
Copy link
Contributor

@kasjer kasjer commented Oct 19, 2023

Only reset cause is supported as there is no common unique id present on those chips.
Unique ID can be put in OTP but there is no single specification for this.

@zephyrbot zephyrbot added platform: Renesas SmartBond Renesas Electronics Corporation, SmartBond area: HWINFO Hardware Information Driver labels Oct 19, 2023
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Dec 19, 2023
@kasjer
Copy link
Contributor Author

kasjer commented Dec 19, 2023

It's hard to make anyone here to review things, let's prolong for another 60 days.

drivers/hwinfo/hwinfo_smartbond.c Outdated Show resolved Hide resolved
drivers/hwinfo/Kconfig Outdated Show resolved Hide resolved
drivers/hwinfo/Kconfig Outdated Show resolved Hide resolved
drivers/hwinfo/hwinfo_smartbond.c Outdated Show resolved Hide resolved
@alexanderwachter
Copy link
Member

@kasjer thanks for the quick fixes. Were you able to test on HW?

@alexanderwachter
Copy link
Member

@kasjer are there boards in the tree where you could add the hwinfo as supported features?

@kasjer
Copy link
Contributor Author

kasjer commented Dec 19, 2023

@alexanderwachter I tested it on da1469x_dk_pro, could you give me a hint on how add supported feature (I'm very new to zephyr)

@alexanderwachter
Copy link
Member

alexanderwachter commented Dec 19, 2023

Just add - hwinfo here:
boards/arm/da1469x_dk_pro/da1469x_dk_pro.yaml
And here:
boards/arm/da14695_dk_usb/da14695_dk_usb.yaml

Only reset cause is supported as there is no common unique id
present on those chips.
Unique ID can be put in OTP but there is no single specification for this.

Signed-off-by: Jerzy Kasenberg <jerzy.kasenberg@codecoup.pl>
Copy link
Member

@alexanderwachter alexanderwachter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kasjer sorry for the delay!

@kasjer
Copy link
Contributor Author

kasjer commented Dec 19, 2023

@alexanderwachter I added hwinfo feature to both boards. I had to rebase branch to include da14695_dk_usb board though so force-pushed changes may look unrelated

@kasjer
Copy link
Contributor Author

kasjer commented Dec 19, 2023

Thanks @kasjer sorry for the delay!

No problem I added this because I really needed to know reset cause in work on other PR so there was no rush, thanks for review and for your help with polishing things.

@fabiobaltieri fabiobaltieri merged commit 4e7950e into zephyrproject-rtos:main Dec 27, 2023
20 checks passed
@kasjer kasjer deleted the kasjer/da1469x-hwinfo branch January 2, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: HWINFO Hardware Information Driver platform: Renesas SmartBond Renesas Electronics Corporation, SmartBond
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants