Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: led_strip: ws2812-rpi_pico-pio: Split the dts definition for LED and controller #70075

Closed
wants to merge 4 commits into from

Conversation

soburi
Copy link
Member

@soburi soburi commented Mar 11, 2024

The dts definition of rpi_pico-pio is divided so that ws2812 can be described with a common dts definition, and the implementation also follows.

Initially, there was some discussion, but with the introduction of #68514, the situation has changed to the point where it is more desirable to be able to reuse the ws2812 DTS.

bff is one example, and in line with this modification, the definition has been changed to one that can be used commonly by the ws2812-gpio and ws2812-rpi_pico-pio drivers.

@soburi soburi changed the title Split pio ws2812 drivers: led_strip: ws2812-rpi_pico-pio: Split the dts definition for LED and controller Mar 11, 2024
…roller

The dts definition of rpi_pico-pio is divided so that ws2812 can be
described with a common dts definition, and the implementation
also follows.

Initially, there was some discussion, but with the introduction of zephyrproject-rtos#68514,
the situation has changed to the point where it is more desirable to
be able to reuse the ws2812 DTS.

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Splitting the LED strip definition into LED strip part and controller part.

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Splitting the LED strip definition into LED strip part and controller part.

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
…nition

Moving LED strip definition into `adafruit_neopixel_grid_bff.overlay`.

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
@soburi soburi marked this pull request as ready for review March 13, 2024 03:24
@zephyrbot zephyrbot added area: Shields Shields (add-on boards) area: Devicetree Binding PR modifies or adds a Device Tree binding area: LED Label to identify LED subsystem platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) labels Mar 13, 2024
@soburi
Copy link
Member Author

soburi commented Mar 13, 2024

@simonguinot
First, I would like to hear your opinion.

@simonguinot
Copy link
Collaborator

@simonguinot First, I would like to hear your opinion.

Hi @soburi,

Please remind me what is the gain in moving the support of the PIO controller (the part related with the WS2812 LED strip) into its own driver (with its own DT compatible) ? Do you plan to share it with another LED driver ? The split rpi_pico_ws2812_controller_pio and ws2812_rpi_pico_pio drivers seem pretty tied to me. So far I can see the complexity we are adding by introducing another compatible but not the benefits :)

Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label May 13, 2024
@github-actions github-actions bot closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: LED Label to identify LED subsystem area: Shields Shields (add-on boards) platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants