-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: led_strip: ws2812-rpi_pico-pio: Split the dts definition for LED and controller #70075
Conversation
88e8e69
to
6150e1a
Compare
…roller The dts definition of rpi_pico-pio is divided so that ws2812 can be described with a common dts definition, and the implementation also follows. Initially, there was some discussion, but with the introduction of zephyrproject-rtos#68514, the situation has changed to the point where it is more desirable to be able to reuse the ws2812 DTS. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Splitting the LED strip definition into LED strip part and controller part. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Splitting the LED strip definition into LED strip part and controller part. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
…nition Moving LED strip definition into `adafruit_neopixel_grid_bff.overlay`. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
6150e1a
to
f8784c7
Compare
@simonguinot |
Hi @soburi, Please remind me what is the gain in moving the support of the PIO controller (the part related with the WS2812 LED strip) into its own driver (with its own DT compatible) ? Do you plan to share it with another LED driver ? The split |
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
The dts definition of rpi_pico-pio is divided so that ws2812 can be described with a common dts definition, and the implementation also follows.
Initially, there was some discussion, but with the introduction of #68514, the situation has changed to the point where it is more desirable to be able to reuse the ws2812 DTS.
bff is one example, and in line with this modification, the definition has been changed to one that can be used commonly by the ws2812-gpio and ws2812-rpi_pico-pio drivers.