driver: bluetooth: hci: Add NXP BT module support on RT1170 EVKB #70815

lylezhu2012 · 2024-03-28T07:27:55Z

Implement UART firmware download driver for NXP BT module.

Only support Murata 2EL M.2 Module on RT1170 EVKB.

subsys/bluetooth/host/hci_core.c

drivers/bluetooth/hci/hci_nxp.c

pdgendt · 2024-06-04T07:15:48Z

@pdgendt can you confirm @lylezhu2012 response to your feedback

My comments have been addressed, I lack the experience to ACK the functionality though. Probably someone with Bluetooth driver knowledge should take a look.

drivers/bluetooth/hci/Kconfig

boards/nxp/mimxrt1170_evk/mimxrt1170_evk_mimxrt1176_cm7_B.overlay

jhedberg · 2024-06-05T20:26:47Z

drivers/bluetooth/hci/Kconfig

+config BT_H4_NXP_CTLR
+	bool "NXP Bluetooth Controller"


Wouldn't it make sense to add the following here:

default y depends on DT_HAS_NXP_BT_HCI_UART_ENABLED

Then you can remove any explicit enablement in the app Kconfig overlays.

...and then it'll also be easier for me to do the conversion as part of #72323

Wouldn't it make sense to add the following here:

default y depends on DT_HAS_NXP_BT_HCI_UART_ENABLED

Then you can remove any explicit enablement in the app Kconfig overlays.

Sorry, the dependency cannot be added.

The Bluetooth controller is module, it can work with any MCU with UART peripheral.

@lylezhu2012 I'm not sure I follow. Even in the case that you describe, those MCUs that have this peripheral connected will still need to have the appropriate devicetree node with compatible = "nxp,bt-hci-uart";, won't they? If not, what is the purpose of the devicetree node?

compatible = "nxp,bt-hci-uart"; is the devicetree node required by NXP Bluetooth Controller. If you want to use NXP Bluetooth Controller, you need to add the devicetree node with compatible = "nxp,bt-hci-uart";.

@lylezhu2012 the compatible strings are used to associate devicetree nodes with drivers. Which driver implements this compatible? You're adding the hci_nxp_setup.c extension driver in this same PR where you add the devicetree binding and compatible, so it seems natural to assume that these go together, even though the c-file currently doesn't #define DT_DRV_COMPAT nxp_bt_hci_uart (which I assumed was primarily because it only supports a single instance at the moment).

Yes, nxp,bt-hci-uart is used for driver hci_nxp_setup.c.

@lylezhu2012 the compatible strings are used to associate devicetree nodes with drivers. Which driver implements this compatible? You're adding the hci_nxp_setup.c extension driver in this same PR where you add the devicetree binding and compatible, so it seems natural to assume that these go together, even though the c-file currently doesn't #define DT_DRV_COMPAT nxp_bt_hci_uart (which I assumed was primarily because it only supports a single instance at the moment).

Yes. Currently, only one instance can be supported.

And I have a question, if does Bluetooth Host support multiple instance? I mean can we call bt_enable multiple times to enable multiple Bluetooth Host?

Yes, nxp,bt-hci-uart is used for driver hci_nxp_setup.c.

So in that case you should be able to apply my proposal wrt default and depends on. If there isn't a node with that compatible string it doesn't make sense to enable the driver.

And I have a question, if does Bluetooth Host support multiple instance? I mean can we call bt_enable multiple times to enable multiple Bluetooth Host?

Not right now. This may become possible at some point in the future, especially thanks to #72323. With that PR you could quite easily construct a host that supports multiple controllers, or an app which exposes multiple controllers over different HCI transports.

So in that case you should be able to apply my proposal wrt default and depends on. If there isn't a node with that compatible string it doesn't make sense to enable the driver.

Updated.

lylezhu2012 · 2024-06-11T10:36:31Z

Fix conflict issue.

jori-nordic · 2024-06-11T12:42:21Z

@lylezhu2012 could you make it also work on MIMXRT1040-EVK, as that's the one you suggested (in #67145) and we bought.

lylezhu2012 · 2024-06-12T02:24:47Z

@lylezhu2012 could you make it also work on MIMXRT1040-EVK, as that's the one you suggested (in #67145) and we bought.

There is a pin conflict on MIMXRT1040-EVK. If PCM pins for handsfree (or AG) are configured by soldering 0 ohm resistors, the board cannot be flashed. So for BR cases, I do not recommend using MIMXRT1040-EVK. MIMXRT1170-EVKB does not have this limitation. That's why I made this PR to support MIMXRT1170-EVKB.

jori-nordic · 2024-06-12T05:29:44Z

If PCM pins for handsfree (or AG) are configured by soldering 0 ohm resistors

We don't really care about the PCM data, it's only for testing that the ACL links and L2CAP channel still work. We could still test, e.g. RFCOMM or A2DP with all-zeroes PCM data.

That board can also be useful to test LE.

the board cannot be flashed

Can you share where in the official documentation I can find this information?

lylezhu2012 · 2024-06-12T05:52:40Z

We don't really care about the PCM data, it's only for testing that the ACL links and L2CAP channel still work. We could still test, e.g. RFCOMM or A2DP with all-zeroes PCM data.
That board can also be useful to test LE.

Got it. I can enable it after the PR merged.

Can you share where in the official documentation I can find this information?

No. We flashed it internally by adding an extra circuit. Or, remove the module manually.

lylezhu2012 · 2024-06-12T05:53:40Z

We don't really care about the PCM data, it's only for testing that the ACL links and L2CAP channel still work. We could still test, e.g. RFCOMM or A2DP with all-zeroes PCM data.
That board can also be useful to test LE.

Got it. I can enable it after the PR merged.

Can you share where in the official documentation I can find this information?

No. We flashed it internally by adding an extra circuit. Or, remove the module or a jumper manually.

Implement UART firmware download driver for NXP BT module. Only support Murata 2EL M.2 module on RT1170EVKB. And only one instance can be supported now. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>

Add Kconfig.nxp to support NXP Bluetooth Chipset. Current only NXP IW612 Chipset (BT_NXP_NW612) has been supported. Add modules/hal_nxp/bt_controller/CMakeLists.txt to determine whether any firmware is selected, and check whether the firmware exists. If the firmware exists, copy the firmware to the temporary folder ${ZEPHYR_BINARY_DIR}/include/ generated/bt_nxp_ctlr_fw.h. OR, raise a fatal error. In file hci_nxp_setup.c, includes the temporary file bt_nxp_ctlr_fw.h. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>

Overlay sram when BT is enabled on board MIMXRT1170 EVKB. Select NXP NW612 chipset. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>

Add `fetch Binary Blobs` section to guide how to fetch binary blobs. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>

Use zephyr_blobs_verify to check the blob file is valid or not. The function zephyr_blobs_verify will check if the file exists. And it checks if the file is valid. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>

Overlay sram when BT is enabled on board MIMXRT1170 EVKB. Select NXP NW612 chipset for Handsfree_ag example Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>

lylezhu2012 · 2024-06-12T06:39:53Z

@jori-nordic , I saw that 72323 has been merged. And I updated the PR to support it.

Please help review it.

jori-nordic · 2024-06-12T06:43:30Z

Will do. I don't have the HW though so I can only try building 👍

lylezhu2012 · 2024-06-12T06:49:42Z

Will do. I don't have the HW though so I can only try building 👍

Sure. Please. I have tested it locally.

lylezhu2012 requested review from mmahadevan108, dleach02, alwa-nordic, jhedberg and Vudentz as code owners March 28, 2024 07:27

zephyrbot added area: Bluetooth Host platform: NXP NXP area: Bluetooth platform: NXP Drivers NXP Semiconductors, drivers area: Devicetree Binding PR modifies or adds a Device Tree binding labels Mar 28, 2024

zephyrbot requested review from danieldegrasse, DerekSnell, EmilioCBen, hermabe, HoZHel, jori-nordic, sjanc, Thalley, theob-pro and yvanderv March 28, 2024 07:28

zephyrbot assigned jhedberg Mar 28, 2024

Thalley removed their request for review March 28, 2024 08:43

lylezhu2012 force-pushed the enable_rt1170evkb_2el_bluetooth branch from 358acad to d202eaf Compare March 28, 2024 08:59

zephyrbot requested a review from decsny March 28, 2024 08:59

lylezhu2012 force-pushed the enable_rt1170evkb_2el_bluetooth branch from d202eaf to 7f5f360 Compare March 28, 2024 11:19

msmttchr reviewed Mar 28, 2024

View reviewed changes

subsys/bluetooth/host/hci_core.c Outdated Show resolved Hide resolved

dleach02 reviewed Mar 28, 2024

View reviewed changes

drivers/bluetooth/hci/hci_nxp.c Outdated Show resolved Hide resolved

lylezhu2012 force-pushed the enable_rt1170evkb_2el_bluetooth branch from 7f5f360 to 9475d5c Compare March 29, 2024 10:30

lylezhu2012 requested review from msmttchr and dleach02 March 29, 2024 10:31

dleach02 previously approved these changes Jun 4, 2024

View reviewed changes

jhedberg reviewed Jun 4, 2024

View reviewed changes

drivers/bluetooth/hci/Kconfig Show resolved Hide resolved

boards/nxp/mimxrt1170_evk/mimxrt1170_evk_mimxrt1176_cm7_B.overlay Outdated Show resolved Hide resolved

lylezhu2012 dismissed dleach02’s stale review via 0587066 June 5, 2024 09:00

lylezhu2012 force-pushed the enable_rt1170evkb_2el_bluetooth branch from 480a66d to 0587066 Compare June 5, 2024 09:00

jhedberg reviewed Jun 5, 2024

View reviewed changes

lylezhu2012 force-pushed the enable_rt1170evkb_2el_bluetooth branch from 0587066 to 8d48cb5 Compare June 11, 2024 10:29

lylezhu2012 requested a review from jhedberg June 11, 2024 10:31

lylezhu2012 force-pushed the enable_rt1170evkb_2el_bluetooth branch from 8d48cb5 to bf10a1d Compare June 11, 2024 10:35

lylezhu2012 requested a review from dleach02 June 12, 2024 04:24

lylezhu2012 added 6 commits June 12, 2024 14:32

driver: bluetooth: hci: Add NXP BT module support

991350d

Implement UART firmware download driver for NXP BT module. Only support Murata 2EL M.2 module on RT1170EVKB. And only one instance can be supported now. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>

Samples: bluetooth: hf: Add board specific configuration

2f8d3d2

Overlay sram when BT is enabled on board MIMXRT1170 EVKB. Select NXP NW612 chipset. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>

boards: mimxrt1170_evk: doc: add blobs support

babed0f

Add `fetch Binary Blobs` section to guide how to fetch binary blobs. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>

module: hal_nxp: bt_controller: Verify if Blob is valid

faf2a89

Use zephyr_blobs_verify to check the blob file is valid or not. The function zephyr_blobs_verify will check if the file exists. And it checks if the file is valid. Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>

Samples: bluetooth: hf_ag: Add board specific configuration

e0695f2

Overlay sram when BT is enabled on board MIMXRT1170 EVKB. Select NXP NW612 chipset for Handsfree_ag example Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>

lylezhu2012 force-pushed the enable_rt1170evkb_2el_bluetooth branch from bf10a1d to e0695f2 Compare June 12, 2024 06:36

jhedberg approved these changes Jun 12, 2024

View reviewed changes

jori-nordic approved these changes Jun 12, 2024

View reviewed changes

dleach02 approved these changes Jun 13, 2024

View reviewed changes

nashif merged commit c4df21e into zephyrproject-rtos:main Jun 13, 2024
29 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

driver: bluetooth: hci: Add NXP BT module support on RT1170 EVKB #70815

driver: bluetooth: hci: Add NXP BT module support on RT1170 EVKB #70815

lylezhu2012 commented Mar 28, 2024

pdgendt commented Jun 4, 2024

jhedberg Jun 5, 2024

jhedberg Jun 5, 2024

lylezhu2012 Jun 6, 2024

jhedberg Jun 6, 2024

lylezhu2012 Jun 6, 2024

jhedberg Jun 7, 2024

lylezhu2012 Jun 7, 2024 •

edited

jhedberg Jun 7, 2024

lylezhu2012 Jun 11, 2024

lylezhu2012 commented Jun 11, 2024

jori-nordic commented Jun 11, 2024

lylezhu2012 commented Jun 12, 2024 •

edited

jori-nordic commented Jun 12, 2024

lylezhu2012 commented Jun 12, 2024

lylezhu2012 commented Jun 12, 2024

lylezhu2012 commented Jun 12, 2024

jori-nordic commented Jun 12, 2024

lylezhu2012 commented Jun 12, 2024

driver: bluetooth: hci: Add NXP BT module support on RT1170 EVKB #70815

driver: bluetooth: hci: Add NXP BT module support on RT1170 EVKB #70815

Conversation

lylezhu2012 commented Mar 28, 2024

pdgendt commented Jun 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lylezhu2012 Jun 7, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lylezhu2012 commented Jun 11, 2024

jori-nordic commented Jun 11, 2024

lylezhu2012 commented Jun 12, 2024 • edited

jori-nordic commented Jun 12, 2024

lylezhu2012 commented Jun 12, 2024

lylezhu2012 commented Jun 12, 2024

lylezhu2012 commented Jun 12, 2024

jori-nordic commented Jun 12, 2024

lylezhu2012 commented Jun 12, 2024

lylezhu2012 Jun 7, 2024 •

edited

lylezhu2012 commented Jun 12, 2024 •

edited