Revert "shell: backends: uart: avoid unnecessary TX IRQs" #72599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robhancocksed please review. |
keith-zephyr
added
the
Hotfix
This reverts commit d2e5eeb. PR zephyrproject-rtos#71172 is causing the bug reported on issue zephyrproject-rtos#72598. Signed-off-by: Keith Short <keithshort@google.com>
keith-zephyr
force-pushed
the
shell-revert
branch
from
7186ec6
to
80c8812
Compare
|
See comment under #72598 - it seems that the bug is really in the uart_ns16550 driver, if I am interpreting the API definition correctly. |
jeremybettis
approved these changes
May 10, 2024
ubieda
approved these changes
May 10, 2024
It's possible that there is a bug in the NS16550 driver. However, the change to the shell is blocking our work downstream. I believe a revert first policy is the correct approach here. If a fix is identified for the NS16550 driver, then the change to the shell can be re-landed. |
coreboot-org-bot
pushed a commit
to coreboot/zephyr-cros
that referenced
this pull request
May 10, 2024
This reverts commit d2e5eeb. PR zephyrproject-rtos/zephyr#71172 is causing the bug reported on issue zephyrproject-rtos/zephyr#72598. Signed-off-by: Keith Short <keithshort@google.com> (cherry picked from commit 80c8812357474ba3e180ca2672238367f63493c9) Manual cherry-pick of: zephyrproject-rtos/zephyr#72599 BUG=b:339878909 TEST=zmake build brox. Run "version" command on EC console. Change-Id: Iace8e08f5a07b24ff7972a63da3b39dde3b5e4e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5531870 Tested-by: Keith Short <keithshort@chromium.org> Reviewed-by: Jeremy Bettis <jbettis@chromium.org> Commit-Queue: Keith Short <keithshort@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d2e5eeb.
PR #71172 is causing the bug reported on issue #72598.