kconfig: Make 'source' non-globbing and use 'gsource' #7402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, Zephyr has used a patched Kconfiglib that turns 'source' into
a globbing source (by replacing 'source' with 'gsource' at the token
level). There's two problems with this:
- The patch needs to be maintained separately
- Misspelled filenames are silently ignored, as they look like glob
patterns that don't match anything
Fix it as follows:
1. Replace all 'source' statements that use wildcards with 'gsource'
2. Remove the custom Kconfiglib patch so that 'source' no longer globs
The sed pattern '/source.*[*?]/s/source/gsource/' was run over all
Kconfig* files to do the replacement.
source's that use environment variables that might contain glob patterns
were manually changed to gsource.
Building the docs in doc/ is a good test, as doc/Makefile deliberately
sets the environment variables to glob up as many Kconfig files as
possible.
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
ulfalizer
requested review from
aescolar,
andrewboie,
andyross,
erwango,
galak,
GAnthony,
kgugala,
MaureenHelm,
nashif,
pgielda,
ramakrishnapallala,
rgundi and
ruuddw
as code owners
Codecov Report
@@ Coverage Diff @@
## master #7402 +/- ##
=======================================
Coverage 55.26% 55.26%
=======================================
Files 467 467
Lines 51641 51641
Branches 9886 9886
=======================================
Hits 28541 28541
Misses 19190 19190
Partials 3910 3910Continue to review full report at Codecov.
|
SebastianBoe
approved these changes
May 8, 2018
carlescufi
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, Zephyr has used a patched Kconfiglib that turns 'source' into
a globbing source (by replacing 'source' with 'gsource' at the token
level). There's two problems with this:
The patch needs to be maintained separately
Misspelled filenames are silently ignored, as they look like glob
patterns that don't match anything
Fix it as follows:
Replace all 'source' statements that use wildcards with 'gsource'
Remove the custom Kconfiglib patch so that 'source' no longer globs
The sed pattern
/source.*[*?]/s/source/gsource/was run over allKconfig* files to do the replacement.
source's that use environment variables that might contain glob patterns
were manually changed to gsource.
Building the docs in doc/ is a good test, as doc/Makefile deliberately
sets the environment variables to glob up as many Kconfig files as
possible.
Signed-off-by: Ulf Magnusson ulfalizer@gmail.com