Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate set buy now #65

Merged
merged 37 commits into from
Jan 23, 2023
Merged

feat: migrate set buy now #65

merged 37 commits into from
Jan 23, 2023

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Dec 20, 2022

Associated Notion Card


1. Pull request checklist

  • Notion card has been moved to the Code Review column
  • Notion card has a link to this PR
  • A reviewer has been assigned to the Notion card

2. PR type

  • feature

3. What is the old behaviour?

Set buy now feature flow had not been migrated to zapp-nfts.

4. What is the new behaviour?

Set buy now migrated to zapp-nfts.

@netlify
Copy link

netlify bot commented Dec 20, 2022

Deploy Preview for zapp-nft ready!

Name Link
🔨 Latest commit b60787c
🔍 Latest deploy log https://app.netlify.com/sites/zapp-nft/deploys/63caaceaf05170000842beee
😎 Deploy Preview https://deploy-preview-65--zapp-nft.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@domw30 domw30 marked this pull request as ready for review January 4, 2023 17:34
@domw30 domw30 requested a review from colbr January 4, 2023 17:35
@domw30
Copy link
Collaborator Author

domw30 commented Jan 5, 2023

Made a couple more additions - added Set Buy Now option to the more options dropdown on the NFT page (if owner).

Conflicts will be resolved after Buy Now is merged to main.

Untitled.12.mp4

@domw30 domw30 requested a review from padala January 20, 2023 15:10
@domw30 domw30 self-assigned this Jan 20, 2023
Copy link
Contributor

@padala padala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than the minor things we discussed in buy now PR. Thanks

@domw30 domw30 merged commit d1928b8 into main Jan 23, 2023
@domw30 domw30 deleted the feat/set-buy-now branch January 23, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants