Feature/375 ci/cd #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/375_CI/CD
Will-Hyde
commented
Jul 1, 2022
Will-Hyde
commented
Jul 1, 2022
| * So if we get that many there's probably more domains we need | ||
| * to fetch. If we got back less, we can stop querying | ||
| */ | ||
| do { |
There was a problem hiding this comment.
Many of these loops had to be altered to pass the linting step.
I made them into do whiles, because it was most similar to the structure they were already using
Remscar
reviewed
Jul 1, 2022
Remscar
approved these changes
Jul 1, 2022
KennyZeroTech
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to lint and test the zns SDK project in circle CI.