Resolves the Sendbird Session Expiry issue #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring initial authentication
dalefukami
approved these changes
Mar 20, 2023
| } | ||
|
|
||
| export class Container extends React.Component<Properties> { | ||
| static mapState(state: RootState): Partial<Properties> { | ||
| static mapState(state: RootState, props: Properties): Partial<Properties> { | ||
| if (!props.context.isAuthenticated) return {}; |
There was a problem hiding this comment.
Does this mean we won't get live updates for public channels?
hkhanouchi
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Resolves the Sendbird Session Expiry issue. This is a multi step phase, we also need to update the Sendbird library.
Why are we making this change?
How do I test this?
Run the tests, Connect as a user, open the browser console, wait 15minutes, observe that there are no Sendbird errors in the console, have someone send you a message, verify the realtime updates occur.