Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WeldingDockingPorts #27

Merged
merged 32 commits into from
Oct 9, 2021

Conversation

yalov
Copy link

@yalov yalov commented Oct 7, 2021

if glued kaboom is enabled and there was in-flight docking, docking ports kaboom together

yalov and others added 30 commits September 14, 2021 19:32
# Version 1.3.99.0 - BETA!
- <p style="color: #FF0000;"><b>DO A CLEAN INSTALL: DELETE EXISTING THEN RE-INSTALL</color></b></p>
- <h1 style="color: #FF0000;"><b>BETA SOFTWARE - CAVEAT EMPTOR</color></b></h1>

- usual spring cleaning and automation

- update folder structure
- update to modern back-end automation
- resolves issue zer0Kerbal#6
  ## Update
  - recompile for KSP 1.12.2
  - update to .NET 4.7.2
  - update to C# 9.0
  - renamed ModuleKaboom.cs to Kaboom.cs
# fix kabooming by kerbal
 * Invoke() with delay instead of OnUpdate(). 
      * scale delay on timewarp. Parts are able to kaboom while timewarp
 * fix decoupling of decouplers on glued kaboom
 * fix missing title and fields for kabooming by kerbal within range
      *  increase range to 10, same as EVA Construction Mode range

![](https://i.imgur.com/gFaxXfN.jpeg)
# folder rename
- Patches to Compatibility 📁
added explicit original license file.
### `Code'

- thank you to ['@flart'](https://forum.kerbalspaceprogram.com/index.php?/profile/181486-flart/) @yalov
- Invoke() with delay instead of OnUpdate().
  - scale delay on timewarp. Parts are able to kaboom while timewarp
- fix decoupling of decouplers on glued kaboom
- fix missing title and fields for kabooming by kerbal within range
  -  increase range to 10, same as EVA Construction Mode range

![](https://i.imgur.com/gFaxXfN.jpeg)

### Updates

- renamed [Patches] folder to [Compatibility]
- ✔ resolves issue zer0Kerbal#12
@zer0Kerbal zer0Kerbal self-requested a review October 8, 2021 07:03
@zer0Kerbal zer0Kerbal self-assigned this Oct 8, 2021
@zer0Kerbal zer0Kerbal added this to the superglue docked docking ports while in flight milestone Oct 8, 2021
@zer0Kerbal zer0Kerbal changed the base branch from Dev-KaboomSuperglue to 1.3.99.2-Beta-3 October 9, 2021 04:31
@zer0Kerbal zer0Kerbal merged commit a2df5ae into zer0Kerbal:1.3.99.2-Beta-3 Oct 9, 2021
@zer0Kerbal
Copy link
Owner

Thank you @yalov ! 💣 - will compile and release 1.3.99.2-Beta-3

zer0Kerbal added a commit that referenced this pull request Oct 10, 2021
# Version 1.3.99.2 - BETA III

- 08 Oct 2021
- Beta Release for Kerbal Space Program [KSP 1.12.2]

***

### Added

- Localization [en-us.cfg]
- ***your localization here***

### `Code'

- thank you to ['@flart'](https://forum.kerbalspaceprogram.com/index.php?/profile/181486-flart/) @yalov
- if glued kaboom is enabled and there was in-flight docking, docking ports kaboom together
- longer ScreenMessage
- remove unnecessary usings
- update .csproj

### Status

  - Issues/MileStones
    - closes #14 - Beta One: 1.3.99.0 (file version 1.3.99.17)
    - updates #33 - Localization project - contributed by zer0kerbal
    - updates #22 - Localization - en-us.cfg (English) - all but one string - contributed by zer0kerbal
    - closes #26 - [ImgBot] Optimize images - contributed by imgbot[bot]
    - closes #27 - WeldingDockingPorts documentation, contributed by yalov
    - closes #29 - upstream for 1.3.99.2-Beta-3 - contributed by zer0Kerbal
    - closes #31 - Merge pull request #29 from zer0Kerbal/master upstream - contributed by zer0Kerbal
    - closes #9 - compile for KSP 1.12.2 - .NET 4.7.2 - C# 10.0 - contributed by zer0Kerbal

 - Bug
   - opened #32 - Kaboom Safety Cover not localized

  - *** Possible future changes ***
    - #33, #20, #21, #22 - more localizations
    - #25 - auto destruct during launch
    - #17, #18 - bigger boom, bigger badda-boom
    - #16 - boom stick
    - #1 - staging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants