Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kaboom Safety Cover not localized #32

Closed
1 task done
zer0Kerbal opened this issue Oct 10, 2021 · 1 comment · Fixed by #59
Closed
1 task done

Kaboom Safety Cover not localized #32

zer0Kerbal opened this issue Oct 10, 2021 · 1 comment · Fixed by #59
Assignees
@zer0Kerbal
Projects
Kaboom! version 1.4.0.0 Bug Triage Localization

Comments

@zer0Kerbal
Copy link
Owner

zer0Kerbal commented Oct 10, 2021 •
edited
Loading

  • Kaboom Safety Cover not localized
@zer0Kerbal zer0Kerbal added the bug label Oct 10, 2021
@zer0Kerbal zer0Kerbal added this to the Kaboom Safety Cover localized milestone Oct 10, 2021
@zer0Kerbal zer0Kerbal self-assigned this Oct 10, 2021
@zer0Kerbal zer0Kerbal added this to To do in Kaboom! version 1.4.0.0 via automation Oct 10, 2021
@zer0Kerbal zer0Kerbal added this to Needs triage in Bug Triage via automation Oct 10, 2021
@zer0Kerbal zer0Kerbal added this to To do in Localization via automation Oct 10, 2021
@zer0Kerbal zer0Kerbal added this to To do in Localization via automation Oct 10, 2021
@zer0Kerbal zer0Kerbal moved this from To do to In progress in Localization Oct 10, 2021
@zer0Kerbal zer0Kerbal moved this from To do to In progress in Localization Oct 10, 2021
@zer0Kerbal zer0Kerbal moved this from To do to In progress in Kaboom! version 1.4.0.0 Oct 10, 2021
@zer0Kerbal zer0Kerbal moved this from Needs triage to High priority in Bug Triage Oct 10, 2021
zer0Kerbal added a commit that referenced this issue Oct 10, 2021
@zer0Kerbal
Version 1.3.99.2 - BETA III
a893dd4 
# Version 1.3.99.2 - BETA III

- 08 Oct 2021
- Beta Release for Kerbal Space Program [KSP 1.12.2]

***

### Added

- Localization [en-us.cfg]
- ***your localization here***

### `Code'

- thank you to ['@flart'](https://forum.kerbalspaceprogram.com/index.php?/profile/181486-flart/) @yalov
- if glued kaboom is enabled and there was in-flight docking, docking ports kaboom together
- longer ScreenMessage
- remove unnecessary usings
- update .csproj

### Status

  - Issues/MileStones
    - closes #14 - Beta One: 1.3.99.0 (file version 1.3.99.17)
    - updates #33 - Localization project - contributed by zer0kerbal
    - updates #22 - Localization - en-us.cfg (English) - all but one string - contributed by zer0kerbal
    - closes #26 - [ImgBot] Optimize images - contributed by imgbot[bot]
    - closes #27 - WeldingDockingPorts documentation, contributed by yalov
    - closes #29 - upstream for 1.3.99.2-Beta-3 - contributed by zer0Kerbal
    - closes #31 - Merge pull request #29 from zer0Kerbal/master upstream - contributed by zer0Kerbal
    - closes #9 - compile for KSP 1.12.2 - .NET 4.7.2 - C# 10.0 - contributed by zer0Kerbal

 - Bug
   - opened #32 - Kaboom Safety Cover not localized

  - *** Possible future changes ***
    - #33, #20, #21, #22 - more localizations
    - #25 - auto destruct during launch
    - #17, #18 - bigger boom, bigger badda-boom
    - #16 - boom stick
    - #1 - staging
@zer0Kerbal
Copy link
Owner Author

Fields["delay"].group.displayName = Localizer.Format("<color=red>#BOOM-SafetyCover</color>");
became
Fields["delay"].group.displayName = System.String.Format("<color=red>" + Localizer.Format("Kaboom Safety Cover") + "</color>");

@zer0Kerbal zer0Kerbal mentioned this issue Oct 14, 2021
Merged
zer0Kerbal added a commit that referenced this issue Oct 14, 2021
@zer0Kerbal
Merge pull request #57 from yalov/1.4.0.0-prerelease
2049527 
# localization fixes + <ru.cfg>
- fix localization of PAW group
- index start with the <<1>> in the localization system
- remove duplicate of root part checking
- set default log setting to false
- ru localization
- closes Localization - Russian (Русский) <ru.cfg>>  #42
- advances Localization - Master  #38
- advances  Kaboom Safety Cover not localized #32
- thank you to @yalov
zer0Kerbal added a commit that referenced this issue Oct 25, 2021
@zer0Kerbal
localization fixes
8b9c3a7 
# Localization fixes
- fix localization of PAW group
- advances Localization - Master  #38
- closes #32 - Kaboom Safety Cover not localized
- closes #56
- updates #55
- closes #54
- closes #37
zer0Kerbal added a commit that referenced this issue Oct 26, 2021
@zer0Kerbal
Version 1.4.0.0 - SuperKlue Implosions!!
676819d 
# Version 1.4.0.0 - SuperKlue Implosions!!
- 25 Oct 2021
- Kerbal Space Program [KSP 1.12.2]
### Added

- added ![][ES] Spanish (Español) (thank you [Tacombel][LINK:tacombel])
- added ![]{RU] Russian (Русский) (thank you [Forums: Flart][LINK:flart] - [Github: yalov][LINK:yalov])
- ***your translation here***

### `Code'

- thank you to ['@flart'][LINK:flart] aka [yalov][LINK:yalov]
- if glued kaboom is enabled and there was in-flight docking, docking ports kaboom together
- longer ScreenMessage
- remove unnecessary usings
- update .csproj

### Updated

- Documentation
  - readme
  - release notes
  - Attribution

### Status

- Features/Issues/Milestones
    - closes #20 - duplicate
    - closes #21 - duplicate
    - closes #22 - duplicate
    - closes #23 - Dev kaboom superglue [pull request] contributed by zer0Kerbal
    - closes #32 - Kaboom Safety Cover not localized
    - closes #35 - 1.3.99.2 beta 3 beta - contributed by zer0Kerbal
    - closes #36 - Create es-es.cfg - contributed by Tacombel
    - closes #37 - Localization - English (United States)] <en-us.cfg> - contributed by zer0Kerbal
    - closes #42 - Localization - Russian (Русский) <ru.cfg> - contributed by yalov
    - closes #52 - Localization - Spanish (Español) <es-es.cfg> - contributed by Tacombel
    - closes #57 - localization fixes + ru - contributed by yalov
    - closes #58 - update ru.cfg localization- contributed by yalov
    - updates #33 - Localization project - contributed by zer0kerbal
- Bug
    - closes #24 - superklue docked docking ports while in flight - thank you to @robin Patenall
    - closes #54 - typo
    - closes #56 - seconds not localized
- *** Possible future changes ***
    - #39, #40, #41, #43, #44, #45, #46, #47, #48, #49, #50, #51 and #53 - more localizations
    - #25 - auto destruct during launch
    - #17, #18 - bigger boom, bigger badda-boom
    - #16 - boom stick
    - #1 - staging
@zer0Kerbal zer0Kerbal mentioned this issue Oct 26, 2021
Merged
Localization automation moved this from In progress to Done Oct 26, 2021
Kaboom! version 1.4.0.0 automation moved this from In progress to Done Oct 26, 2021
Bug Triage automation moved this from High priority to Closed Oct 26, 2021
Localization automation moved this from In progress to Done Oct 26, 2021
zer0Kerbal added a commit that referenced this issue Oct 26, 2021
@zer0Kerbal
Merge pull request #59 from zer0Kerbal/1.4.0.0-prerelease
1f24791 
# Version 1.4.0.0 - SuperKlue Implosions!!
- 25 Oct 2021  
- Kerbal Space Program [KSP 1.12.2]
### Added  

- added ![][ES] Spanish (Español) (thank you [Tacombel][LINK:tacombel])
- added ![][RU] Russian (Русский) (thank you [Forums: Flart][LINK:flart] - [Github: yalov][LINK:yalov])
- ***your translation here***

### `Code'

- thank you to ['@flart'][LINK:flart] aka [yalov][LINK:yalov]
- if glued kaboom is enabled and there was in-flight docking, docking ports kaboom together
- longer ScreenMessage
- remove unnecessary usings
- update .csproj

### Updated

- Documentation
  - readme
  - release notes
  - Attribution
  
### Status

- Features/Issues/Milestones
    - closes #20 - duplicate
    - closes #21 - duplicate
    - closes #22 - duplicate
    - closes #23 - Dev kaboom superglue [pull request] contributed by zer0Kerbal
    - closes #32 - Kaboom Safety Cover not localized
    - closes #35 - 1.3.99.2 beta 3 beta - contributed by zer0Kerbal
    - closes #36 - Create es-es.cfg - contributed by Tacombel
    - closes #37 - Localization - English (United States)] <en-us.cfg> - contributed by zer0Kerbal
    - closes #42 - Localization - Russian (Русский) <ru.cfg> - contributed by yalov
    - closes #52 - Localization - Spanish (Español) <es-es.cfg> - contributed by Tacombel
    - closes #57 - localization fixes + ru - contributed by yalov
    - closes #58 - update ru.cfg localization- contributed by yalov
    - updates #33 - Localization project - contributed by zer0kerbal
- Bug
    - closes #24 - superklue docked docking ports while in flight - thank you to @robin Patenall
    - closes #54 - typo
    - closes #56 - seconds not localized
- *** Possible future changes ***
    - #39, #40, #41, #43, #44, #45, #46, #47, #48, #49, #50, #51 and #53 - more localizations 
    - #25 - auto destruct during launch
    - #17, #18 - bigger boom, bigger badda-boom
    - #16 - boom stick
    - #1 - staging

[RU]: https://raw.githubusercontent.com/zer0Kerbal/zer0Kerbal/zed'K/Localization/img/Russian-flag-sm.png "Русский" 
[ES]: https://raw.githubusercontent.com/zer0Kerbal/zer0Kerbal/zed'K/Localization/img/Spanish-flag-sm.png "Español" 
[EN]: https://raw.githubusercontent.com/zer0Kerbal/zer0Kerbal/zed'K/Localization/img/American-flag-sm.png "American English" 
[LINK:russnash37]: https://forum.kerbalspaceprogram.com/index.php?/profile/77512-russnash37/ "Forums: RussNash37"  
[LINK:russnash]: https://github.com/russnash "GitHub: russnash"  
[LINK:tacombel]: https://github.com/Tacombel "Tacombel"  
[LINK:flart]: https://forum.kerbalspaceprogram.com/index.php?/profile/181486-flart/ "Flart"  
[LINK:yalov]: https://github.com/yalov "yalov"  
[LINK:zer0Kerbal]: https://forum.kerbalspaceprogram.com/index.php?/profile/190933-zer0kerbal/ "zer0Kerbal"
@zer0Kerbal zer0Kerbal removed this from Done in Localization Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zer0Kerbal zer0Kerbal

Labels
None yet
Projects
Localization
  
Done
Bug Triage
  
Closed
Kaboom! version 1.4.0.0
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 1.4.0.0 - SuperKlue Implosions!! zer0Kerbal/Kaboom
1 participant
@zer0Kerbal