Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth 1.0a removal #354

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Conversation

mmd-osm
Copy link
Collaborator

@mmd-osm mmd-osm commented Dec 20, 2023

This pull request completely removes OAuth 1.0a, including all test cases, config options, manual page details, etc.
Redaction related unit tests which were based on OAuth 1.0a before are now using OAuth 2.0.

As a side effect of this PR, we're reducing the number of db connections from 3 to 2 per process.

Create a new release 0.8.1 0.9.0 before merging this PR.

Don't merge right away, since it would impact some unit tests on master.apis.dev.

@mmd-osm mmd-osm added this to the v0.9.0 milestone Dec 20, 2023
@mmd-osm mmd-osm linked an issue Dec 20, 2023 that may be closed by this pull request
@Zverik

This comment was marked as off-topic.

@mmd-osm

This comment was marked as off-topic.

@mmd-osm mmd-osm marked this pull request as ready for review December 21, 2023 19:55
@mmd-osm mmd-osm changed the base branch from master to oauth_removal December 24, 2023 17:20
@mmd-osm mmd-osm force-pushed the patch/oauth10a_removal branch 2 times, most recently from 30e30b7 to 0749508 Compare January 3, 2024 16:33
@mmd-osm mmd-osm deleted the branch zerebubuth:master January 3, 2024 16:40
@mmd-osm mmd-osm closed this Jan 3, 2024
@mmd-osm mmd-osm reopened this Jan 3, 2024
@mmd-osm mmd-osm mentioned this pull request Feb 17, 2024
@mmd-osm mmd-osm changed the base branch from oauth_removal to master March 17, 2024 21:47
@mmd-osm
Copy link
Collaborator Author

mmd-osm commented Mar 27, 2024

We will wait a bit more for Organic Maps to merge their OAuth 1.0a -> OAuth 2.0 PR. Target date is after their April release, so probably within in the next couple of weeks.

Otherwise merging this PR will break their unit tests on master.apis.dev.openstreetmap.org.

@mmd-osm
Copy link
Collaborator Author

mmd-osm commented Apr 12, 2024

organicmaps/organicmaps#7333 has been merged in the meantime -> "waiting downstream" label removed. Merging is planned shortly after the 0.9.1 release.

@mmd-osm mmd-osm merged commit 6dd16a5 into zerebubuth:master Apr 16, 2024
6 checks passed
@mmd-osm mmd-osm deleted the patch/oauth10a_removal branch July 13, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for OAuth 1.0a and Basic Auth
2 participants