build: add dockerfile #25
Conversation
🥳 Congratulations 🎉Congrats on making your first Pull Request in the Zero To Mastery Organization! ZTM Profile BadgeIf you'd like the ZTM Badge to show up on your profile, you will need to follow this guide! |
|
🙏 Thanks for your pull request @gustavokuhl, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
I like both the Docker idea and the stdin reading idea, but you changed the files in the example folder, which the README states should not be changed. Please make the changes in the Thanks! |
add stdin behavior for community_version and removes incorrect changes as requested on PR
|
🙏 Thanks for your pull request @gustavokuhl, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
|
Building the image: docker build -t ascii-art .Running the container: docker run -e COLUMNS=$COLUMNS -e LINES=$LINES -i ascii < example/ztm-logo.pngThe tags COLUMNS and LINES are need because container default values are too tight. |
|
🙏 Thanks for your pull request @gustavokuhl, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated! Some of the most popular are PR Statistics
|
Adds Dockerfile to the project, as well as a description in the README (I think it can be improved, and I'm open to suggestions), and changes the handle_image_conversion method, to receive an Image object as a parameter, which can now also be read from stdin.