Worker#unregister_worker shouldn't call done_working

unregister_worker faulty increments Stat[:processed] by calling done_working
zerobearing2 · Feb 9, 2010 · 66f7813 · 66f7813
1 parent 565e076
commit 66f7813
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/resque/worker.rb b/lib/resque/worker.rb
@@ -312,8 +312,6 @@ def register_worker
 
     # Unregisters ourself as a worker. Useful when shutting down.
     def unregister_worker
-      done_working
-
       redis.srem(:workers, self)
       redis.del("worker:#{self}:started")
 

diff --git a/test/worker_test.rb b/test/worker_test.rb
@@ -226,4 +226,9 @@
       assert_equal 1, Resque.workers.size
     end
   end
+
+  test "Processed jobs count" do
+    @worker.work(0)
+    assert_equal 1, Resque.info[:processed]
+  end
 end