Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java demos use package metadata directive (#24) #27

Merged
merged 5 commits into from
Dec 13, 2018
Merged

Java demos use package metadata directive (#24) #27

merged 5 commits into from
Dec 13, 2018

Conversation

rysamurai
Copy link

The Java demos in the ice-demos repository now demonstrate the package metadata directive.
"Ice.Default.Package" property is set after the communicator is created, as opposed to being set in the config files.

@rysamurai rysamurai requested a review from externl October 3, 2018 18:25
@bernardnormier
Copy link
Member

The package metadata is missing for some demos: Chat, Database and android.

@rysamurai
Copy link
Author

Thanks for letting me know, I'll get to work on adding it right away.

@rysamurai rysamurai added csharp and removed csharp labels Dec 7, 2018
@rysamurai rysamurai changed the base branch from 3.7 to 3.7.2-rc December 7, 2018 20:07
@bernardnormier bernardnormier self-assigned this Dec 7, 2018
@bernardnormier
Copy link
Member

The updated Chat and Manual/simpleFilesystem don't compile, most likely because of a clean issue (./gradlew clean apparently didn't clean old generated code).

Then, a few demos already used packages:

Manual/evictor/EvictorBase.java:package Evictor;
Manual/evictor/LinkedList.java:package Evictor;
Manual/lifecycle/FilesystemI/DirectoryI.java:package FilesystemI;
Manual/lifecycle/FilesystemI/FileI.java:package FilesystemI;
Manual/lifecycle/FilesystemI/NodeI.java:package FilesystemI;
Chat/src/main/java/ChatDemoGUI/ChatRoomCallbackI.java:package ChatDemoGUI;
Chat/src/main/java/ChatDemoGUI/ChatDemoGUIFactory.java:package ChatDemoGUI;
Chat/src/main/java/ChatDemoGUI/StatusBarI.java:package ChatDemoGUI;
Chat/src/main/java/ChatDemoGUI/Coordinator.java:package ChatDemoGUI;
Chat/src/main/java/ChatDemoGUI/LoginView.java:package ChatDemoGUI;
Chat/src/main/java/ChatDemoGUI/ChatView.java:package ChatDemoGUI;
Chat/src/main/java/ChatDemoGUI/ChatUtils.java:package ChatDemoGUI;
Chat/src/main/java/ChatDemoGUI/LoginInfo.java:package ChatDemoGUI;
Chat/src/main/java/ChatDemoGUI/MainView.java:package ChatDemoGUI;

For the Manual demos, I think we should move these classes to the top-level package, just like Client and Server. And of course update the Ice Manual.

For the Chat demo, I would move this code from package ChatDemoGUI to package com.zeroc.demos.Chat (like the generated code for that demo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants